[20.10] Revert "Ignore SIGURG on Linux." #2987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3c87f01. This commit introduced two regressions; - spurious "Unsupported signal: <nil>. Discarding." - docker start --attach hanging if the container does not have a TTY attached Reverting for now, while we dug deeper into what's causing the regression. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This was referenced Mar 1, 2021
tonistiigi
approved these changes
Mar 2, 2021
tiborvass
approved these changes
Mar 2, 2021
kaosagnt
added a commit
to kaosagnt/boot2docker-xfs-ng
that referenced
this pull request
Mar 3, 2021
Revert docker/cli#2960 to fix hanging in docker start --attach and remove spurious “Unsupported signal: . Discarding." messages [docker/cli#2987](docker/cli#2987)
kaosagnt
added a commit
to kaosagnt/toolbox2docker
that referenced
this pull request
Mar 3, 2021
https://docs.docker.com/engine/release-notes/ 2021-03-02 Client Revert docker/cli#2960 to fix hanging in docker start --attach and remove spurious “Unsupported signal: . Discarding." messages docker/cli#2987
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for 20.10, this fixes moby/moby#42093 docker 20.10.4 on linux and windows breaks docker-compose run -T
for 20.10, this fixes #2989
docker start -adoes not start containersThis reverts commit 3c87f01 (#2960) which was a backport of #2929
This commit introduced two regressions;
Reverting for now, while we dig deeper into what's causing the regression.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)