[20.10 backport] Ignore SIGURG on Linux. #2960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In go1.14+, SIGURG is used by the runtime to handle preemtable system calls. In practice this signal caught *frequently*. For reference: https://go.googlesource.com/proposal/+/master/design/24543-non-cooperative-preemption.md golang/go#37942 Signed-off-by: Brian Goff <cpuguy83@gmail.com> (cherry picked from commit fff164c) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
@silvin-lubecki @cpuguy83 ptal |
Codecov Report
@@ Coverage Diff @@
## 20.10 #2960 +/- ##
==========================================
+ Coverage 57.02% 57.08% +0.06%
==========================================
Files 297 299 +2
Lines 18666 18676 +10
==========================================
+ Hits 10644 10661 +17
+ Misses 7157 7149 -8
- Partials 865 866 +1 |
cpuguy83
approved these changes
Feb 4, 2021
This was referenced Mar 1, 2021
Closed
3 tasks
kaosagnt
added a commit
to kaosagnt/boot2docker-xfs-ng
that referenced
this pull request
Mar 3, 2021
Revert docker/cli#2960 to fix hanging in docker start --attach and remove spurious “Unsupported signal: . Discarding." messages [docker/cli#2987](docker/cli#2987)
kaosagnt
added a commit
to kaosagnt/toolbox2docker
that referenced
this pull request
Mar 3, 2021
https://docs.docker.com/engine/release-notes/ 2021-03-02 Client Revert docker/cli#2960 to fix hanging in docker start --attach and remove spurious “Unsupported signal: . Discarding." messages docker/cli#2987
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #2929
In go1.14+, SIGURG is used by the runtime to handle preemtable system
calls.
In practice this signal is caught frequently.
For reference:
https://go.googlesource.com/proposal/+/master/design/24543-non-cooperative-preemption.md
golang/go#37942