use compose-go version fixing extra_hosts unicity issue #12159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glours
requested review from
a team,
ndeloof and
jhrotko
and removed request for
a team
ndeloof
reviewed
Sep 24, 2024
go.mod
Outdated
| @@ -192,3 +192,5 @@ require ( | |||
| sigs.k8s.io/yaml v1.3.0 // indirect | |||
| tags.cncf.io/container-device-interface v0.8.0 // indirect | |||
| ) | |||
|
|
|||
| replace github.com/compose-spec/compose-go/v2 => github.com/glours/compose-go/v2 v2.0.0-20240924124937-38f94a79402c | |||
There was a problem hiding this comment.
Just to test again Compose CI until we release a new version of compose-go
There was a problem hiding this comment.
I marked the PR as draft for now
There was a problem hiding this comment.
right, I got confused for this reason as I got notified on this one first :)
glours
force-pushed
the
fix-extra_hosts_unicity-issue
branch
2 times, most recently
from
697c12b
to
2ba208e
Compare
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
glours
force-pushed
the
fix-extra_hosts_unicity-issue
branch
from
2ba208e
to
9a7a95f
Compare
jhrotko
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Bump
compose-goversion fixingextra_hostsunicity issueRelated issue
fixes #12155
(not mandatory) A picture of a cute animal, if possible in relation to what you did