[master] rpm: remove CentOS/RHEL 7 leftovers #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
changed the title
We still need to support RHEL 8, so I need to drop this one |
These conditionals were added in incfee3a64519ec5361b406eb6439aed7e3768b7c2 and bb4bd31, because weak dependencies were introduced in CentOS/RHEL 8 and higher (see [1], [2]), but not yet available in CentOS/RHEL 7. Now that CentOS/RHEL 7 reached EOL and removed from our packaging (in 88a6cdc, 67c89e9), all supported RPM distros now support weak dependencies, so we can remove the conditionals. [1]: https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/packaging_and_distributing_software/new-features-in-rhel-8_packaging-and-distributing-software#support-for-weak-dependencies_new-features-in-rhel-8 [2]: https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/packaging_and_distributing_software/new-features-in-rhel-8_packaging-and-distributing-software#boolean-dependencies-syntax Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Now that CentOS/RHEL 7 and 8 reached EOL and removed from our packaging (in 88a6cdc, 67c89e9), we can remove the patch. > RLIMIT_NOFILE defaults to an unusable value on EL 7 systems, but more > modern systems have sane defaults. As such, patch the systemd unit only > on EL 7 systems to ensure correct behaviour. This reverts commit 4e7a147. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
remove_rhel7_rhel8_remnants
branch
from
df15be2 to
57e2252
Compare
vvoland
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
rpm: remove conditional weak-dependencies for CentOS/RHEL 7
These conditionals were added in incfee3a64519ec5361b406eb6439aed7e3768b7c2
and bb4bd31, because weak dependencies were
introduced in CentOS/RHEL 8 and higher (see 1, 2), but not yet available
in CentOS/RHEL 7.
Now that CentOS/RHEL 7 and 8 reached EOL and removed from our packaging
(in 88a6cdc, 67c89e9),
all supported RPM distros now support weak dependencies, so we can remove
the conditionals.
rpm: remove RLIMIT_NOFILE patch for EL 7 systems
Now that CentOS/RHEL 7 and 8 reached EOL and removed from our packaging
(in 88a6cdc, 67c89e9),
we can remove the patch.
This reverts commit 4e7a147.