[master] rpm: recommend, not require "docker-ce-rootless-extras" where possible #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deb pacakges have this dependency as "recommends", but older versions of yum (RHEL7 / CentOS 7) do not support this. and only support "requires". This patch uses a similar approach as bb4bd31 did for the CLI, and changes the dependency to be "recommends" where possible, falling back to "requires" for older rpm versions. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
neersighted
approved these changes
Sep 20, 2023
thaJeztah
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deb pacakges have this dependency as "recommends", but older versions of yum (RHEL7 / CentOS 7) do not support this. and only support "requires".
This patch uses a similar approach as bb4bd31 did for the CLI, and changes the dependency to be "recommends" where possible, falling back to "requires" for older rpm versions.