Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

archive for older releases #162

Closed
riezebosch opened this issue Oct 21, 2016 · 15 comments
Closed

archive for older releases #162

riezebosch opened this issue Oct 21, 2016 · 15 comments

Comments

@riezebosch
Copy link

Expected behavior

I'm creating a chocolatey package to install docker for windows. It is common the tie the package to the specific release of the software and the package includes the hash to validate the download. Currently it is only possible to download the latest release. The effect of this is twofold:

  1. The install of the package will with every new release due to a changing checksum
  2. It will not be possible to install older specific releases.

Actual behavior

Only latest version available.

Information

Some other docker packages provide releases via github and seem to include a version number specific to that release. Please, do the same thing for the docker for windows installation.

Steps to reproduce the behavior

  1. ...
  2. ...
@friism
Copy link

friism commented Oct 21, 2016

Thanks for opening this issue!

It's not really meaningful for the the installers to be versioned since they're just envolopes around the app, and even if you get an old envelope, the app will immediately start auto-updating once install completes.

Your effort is appreciated, but I'm not sure a Chocolatey package is required - Docker for Windows will install unattended with two commands:

Invoke-WebRequest "https://download.docker.com/win/beta/InstallDocker.msi" -OutFile "$env:TEMP\docker.msi" -UseBasicParsing
Start-Process $env:TEMP\docker.msi -ArgumentList '/quiet' -Wait

@riezebosch
Copy link
Author

Okay, but then I can imagine that the 'envelopes' aren't updating that fast so the installer will be sort of stable? I believe that installation through chocolatey still makes sense even though the download and installation isn't that hard from scripting. The contents of the package isn't that complicated either. But is nice to have a single entry point for all your installations and provisioning.

@friism
Copy link

friism commented Mar 10, 2017

We're not currently planning to publish installers for old packages since those will container known bugs and possibly security problems and we don't want to encourage users to install those. I'm closing this issue for now.

@friism friism closed this as completed Mar 10, 2017
@kcd83
Copy link

kcd83 commented Mar 14, 2017

What about instructing docker for windows to install an older version of the engine?

Known bugs can be in new releases too. For example OpenShift has problems with parsing the new version scheme.

@friism
Copy link

friism commented Mar 14, 2017

@kcd83 thanks for adding that perspective. I'm really sorry that the version change caused problems for software that you want to run on Docker. Strictly speaking, however, it's not a bug in Docker that software running on Docker fails to parse a Docker version string.

As mentioned above, it's not attractive for us to make (for example) Docker 1.13.X or Docker 1.12.X available through Docker for Windows since they're no longer maintained and contain known security issues and bugs.

It looks like Openshift already has a fix: openshift/origin#13204

@djensen47
Copy link

djensen47 commented Jan 10, 2018

How about when you push out a release that horks existing installs to the point that Docker just can't be used on the system any more?

@riezebosch
Copy link
Author

I discovered direct download links in the mean time so installing with chocolatey is already a pinned version 😄

@djensen47
Copy link

Awesome, yeah I eventually discovered the same thing. Chocolately FTW!

@ehazlett
Copy link

@friism I get your comment about wanting to have people on the latest and greatest but I just ran into an issue that I've confirmed on 17.12 and 18.01 but works fine on 17.06. This is a case where I would take an older more stable build over latest features and bug fixes. Ultimately I just need a version of Docker that works.

@friism
Copy link

friism commented Jan 18, 2018

@ehazlett congrats, we started adding download links in the release notes last fall: docker/for-mac#1120 (comment)

https://docs.docker.com/docker-for-windows/release-notes/#docker-community-edition-17062-ce-win27-2017-09-06-stable

@ehazlett
Copy link

ehazlett commented Jan 18, 2018 via email

@pd93
Copy link

pd93 commented Feb 7, 2018

@friism Out of curiosity, the download links seem to have stopped since 17.09.0. I'd like to downgrade to 17.09.1 to resolve this problem, but currently only 17.09 is available. If possible, I'd prefer to have the patched version for reasons you stated above (security/bugs etc).

@riezebosch
Copy link
Author

riezebosch commented Feb 7, 2018

Extracted from my package the url seems to work fine.

@pd93
Copy link

pd93 commented Feb 7, 2018

@riezebosch Thanks for the link. It seems to work well - though I'd still prefer for this to be officially supported rather than relying on Chocolatey support.

@docker-robott
Copy link
Collaborator

Closed issues are locked after 30 days of inactivity.
This helps our team focus on active issues.

If you have found a problem that seems similar to this, please open a new issue.

Send feedback to Docker Community Slack channels #docker-for-mac or #docker-for-windows.
/lifecycle locked

@docker docker locked and limited conversation to collaborators Jun 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

9 participants