[1.5] cluster up: warn on error parsing Docker version

[csrwng]

The latest version of Docker for Mac/Windows uses the Community Edition
versioning scheme. This causes 'cluster up' to halt with an error because
the new version cannot be parsed by the 'semver' library. This commit
changes the behavior to display a warning instead of exiting with an
error.

[csrwng]

1.5 backport of #13201

[csrwng]

@bparees ptal

[bparees]

[merge]

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/761/) (Image: devenv-rhel7_6027)

[openshift-bot]

Evaluated for origin merge up to f49d0c7

[openshift-bot]

[Test]ing while waiting on the merge queue

[openshift-bot]

Evaluated for origin test up to f49d0c7

[openshift-bot]

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/761/) (Base Commit: 45bf13e)

[luciddreamz]

@csrwng After upgrading the oc tools to 3.5+ I no longer see this error when running oc cluster up, however, I cannot actually deploy applications (possibly a kube issue?):

Error syncing pod, skipping: failed to "StartContainer" for "POD" with RunContainerError: "runContainer: docker: failed to parse docker version \"17.03.0-ce\": illegal zero-prefixed version component \"03\" in \"17.03.0-ce\"" 

[csrwng]

@luciddreamz yes it is a kubelet issue ... #13281
However, I was able to still run pods with v1.5.0-alpha.3 of origin. I haven't tried with the ocp version.

[luciddreamz]

@csrwng For reference I was using origin v1.5.0-rc.0

[csrwng]

@luciddreamz please try with --version=v1.5.0-alpha.3 and see if pods work

[gjayaram]

@csrwng i am getting the kubelet error in OCP v3.5.5.5.

here is what i tried....

$ docker version
Client:
Version: 1.13.1
API version: 1.26
Go version: go1.7.5
Git commit: 092cba3
Built: Wed Feb 8 08:47:51 2017
OS/Arch: darwin/amd64

Server:
Version: 1.13.1
API version: 1.26 (minimum version 1.12)
Go version: go1.7.5
Git commit: 092cba3
Built: Wed Feb 8 08:47:51 2017
OS/Arch: linux/amd64
Experimental: true

$ docker-machine ls
NAME ACTIVE DRIVER STATE URL SWARM DOCKER ERRORS
default - virtualbox Stopped Unknown
openshift - virtualbox Running tcp://192.168.99.100:2376 v17.04.0-ce

BTW, not sure why the DOCKER VERSION is v17.04.0-ce when i am running the Docker 1.13.1 on my mac.

$ oc cluster up --image=registry.access.redhat.com/openshift3/ose --version="latest" --create-machine

-- Checking OpenShift client ... OK
-- Create Docker machine ...
Creating docker-machine openshift
-- Checking Docker client ... OK
-- Checking Docker version ...
WARNING: Cannot verify Docker version
-- Checking for existing OpenShift container ... OK
-- Checking for registry.access.redhat.com/openshift3/ose:latest image ...
Pulling image registry.access.redhat.com/openshift3/ose:latest
....
....

-- Server Information ...
OpenShift server started.
The server is accessible via web console at:
https://192.168.99.100:8443

You are logged in as:
User: developer
Password: developer

To login as administrator:
oc login -u system:admin

However, when i looked into the default project, the kubelet issue still remains same:

$oc get events -w
...
2017-04-18 21:06:07 +0530 IST 2017-04-18 20:53:11 +0530 IST 61 docker-registry-1-deploy Pod Warning FailedSync {kubelet 192.168.99.100} Error syncing pod, skipping: failed to "StartContainer" for "POD" with RunContainerError: "runContainer: docker: failed to parse docker version "17.04.0-ce": illegal zero-prefixed version component "04" in "17.04.0-ce""

LASTSEEN FIRSTSEEN COUNT NAME KIND SUBOBJECT TYPE REASON SOURCE MESSAGE
2017-04-18 21:06:12 +0530 IST 2017-04-18 20:53:11 +0530 IST 59 router-1-deploy Pod Warning FailedSync {kubelet 192.168.99.100} Error syncing pod, skipping: failed to "StartContainer" for "POD" with RunContainerError: "runContainer: docker: failed to parse docker version "17.04.0-ce": illegal zero-prefixed version component "04" in "17.04.0-ce""
...

Pl help.

[bparees]

I don't think the fix was put into OCP3.5 as that is not a supported docker version for OCP.