Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some linting issues (errCheck, misspell, unconvert) #84

Merged
merged 7 commits into from
Jul 22, 2021
Merged

fix some linting issues (errCheck, misspell, unconvert) #84

merged 7 commits into from
Jul 22, 2021

Commits on Jul 22, 2021

  1. nat: remove unused portSpecTemplate const (deadcode) 

    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @thaJeztah
    thaJeztah committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    83a13b4 View commit details
    Browse the repository at this point in the history

  2. fix some linting issues (errCheck, misspell, unconvert) 

    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @thaJeztah
    thaJeztah committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    0a52a47 View commit details
    Browse the repository at this point in the history

  3. proxy: skip TestUDPWriteError on macOS 

    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @thaJeztah
    thaJeztah committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    12f5bb5 View commit details
    Browse the repository at this point in the history

  4. tlsconfig: skip ExclusiveRootPools tests on Windows 

    - TestConfigClientExclusiveRootPools
- TestConfigServerExclusiveRootPools

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @thaJeztah
    thaJeztah committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    13b326b View commit details
    Browse the repository at this point in the history

  5. sockets: add missing build tags 

      level=error msg="[linters context] typechecking error: D:\\a\\go-connections\\go-connections\\sockets\\unix_socket_test.go:41:12: undeclared name: NewUnixSocket"
  level=error msg="[linters context] typechecking error: D:\\a\\go-connections\\go-connections\\sockets\\unix_socket_test.go:54:12: undeclared name: NewUnixSocketWithOpts"
  level=error msg="[linters context] typechecking error: D:\\a\\go-connections\\go-connections\\sockets\\unix_socket_test.go:54:40: undeclared name: WithChown"
  level=error msg="[linters context] typechecking error: D:\\a\\go-connections\\go-connections\\sockets\\unix_socket_test.go:54:61: undeclared name: WithChmod"
  level=error msg="[linters context] typechecking error: D:\\a\\go-connections\\go-connections\\sockets\\unix_socket_test.go:66:35: Stat_t not declared by package syscall"

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @thaJeztah
    thaJeztah committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    9cbe10e View commit details
    Browse the repository at this point in the history

  6. sockets: skip tests that require root 

    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @thaJeztah
    thaJeztah committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    370f202 View commit details
    Browse the repository at this point in the history

  7. sockets: defaultTimeout is unused on Windows (deadcode) 

    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    @thaJeztah
    thaJeztah committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    fcf9eb7 View commit details
    Browse the repository at this point in the history