Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some linting issues (errCheck, misspell, unconvert) #84

Merged
merged 7 commits into from
Jul 22, 2021

Conversation

thaJeztah
Copy link
Member

No description provided.

@thaJeztah
Copy link
Member Author

Arf.. of course 😂

=== RUN   TestConfigClientExclusiveRootPools
    config_test.go:595: Unable to verify certificate 1: x509: certificate has expired or is not yet valid: current time 2021-07-21T14:20:01Z is after 2021-03-17T16:40:46Z

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- TestConfigClientExclusiveRootPools
- TestConfigServerExclusiveRootPools

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
  level=error msg="[linters context] typechecking error: D:\\a\\go-connections\\go-connections\\sockets\\unix_socket_test.go:41:12: undeclared name: NewUnixSocket"
  level=error msg="[linters context] typechecking error: D:\\a\\go-connections\\go-connections\\sockets\\unix_socket_test.go:54:12: undeclared name: NewUnixSocketWithOpts"
  level=error msg="[linters context] typechecking error: D:\\a\\go-connections\\go-connections\\sockets\\unix_socket_test.go:54:40: undeclared name: WithChown"
  level=error msg="[linters context] typechecking error: D:\\a\\go-connections\\go-connections\\sockets\\unix_socket_test.go:54:61: undeclared name: WithChmod"
  level=error msg="[linters context] typechecking error: D:\\a\\go-connections\\go-connections\\sockets\\unix_socket_test.go:66:35: Stat_t not declared by package syscall"

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Copy link

@djs55 djs55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, lgtm

@thaJeztah thaJeztah merged commit 32b7f00 into docker:master Jul 22, 2021
@thaJeztah thaJeztah deleted the fix_linting branch July 22, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants