Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tlsconfig: update expired Let’s Encrypt CA fixture #86

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

thaJeztah
Copy link
Member

to fix the failures on #84

It expired on Mar 17, 2021, causing tests to fail:

=== RUN   TestConfigClientExclusiveRootPools
    config_test.go:595: Unable to verify certificate 1: x509: certificate has expired or is not yet valid: current time 2021-07-21T14:20:01Z is after 2021-03-17T16:40:46Z

It expired on Mar 17, 2021, causing tests to fail:

    === RUN   TestConfigClientExclusiveRootPools
        config_test.go:595: Unable to verify certificate 1: x509: certificate has expired or is not yet valid: current time 2021-07-21T14:20:01Z is after 2021-03-17T16:40:46Z

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Copy link
Contributor

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 790233e into docker:master Jul 21, 2021
@thaJeztah thaJeztah deleted the update_letsencrypt_fixture branch July 21, 2021 22:51
@akerouanton akerouanton mentioned this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants