Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8 Fatal Error because of incompatible signatures #3791

Closed
orklah opened this issue Dec 21, 2019 · 2 comments
Closed

PHP 8 Fatal Error because of incompatible signatures #3791

orklah opened this issue Dec 21, 2019 · 2 comments
Assignees
@morozov
Labels
Connections Duplicate PDO

Comments

@orklah
Copy link

orklah commented Dec 21, 2019

Bug Report

Q A
BC Break no
Version 2.10

Summary

I tried to install CI with PHP 8 in my project and I get a Fatal Error because of incompatible signatures

Current behaviour

PHP Fatal error:  Declaration of Doctrine\DBAL\Driver\PDOConnection::query() must be compatible with PDO::query(string $statement) in /home/runner/work/inspar/inspar/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php on line 70

Is this a known issue? Maybe it's a little early to worry about PHP 8?
@morozov
Copy link
Member

morozov commented Dec 21, 2019

Yes, it's a known issue (#3770). Closing as duplicate.

@morozov morozov closed this as completed Dec 21, 2019
@morozov morozov self-assigned this Dec 21, 2019
This was referenced May 21, 2020
Closed
Merged
nicolas-grekas added a commit to symfony/symfony that referenced this issue May 23, 2020
@nicolas-grekas
minor #36895 Skip Doctrine DBAL on php 8 until we have a compatible v…
2799d55 
…ersion (derrabus)

This PR was merged into the 3.4 branch.

Discussion
----------

Skip Doctrine DBAL on php 8 until we have a compatible version

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #36872
| License       | MIT
| Doc PR        | N/A

This PR skips all tests on php 8 that would trigger an autoload on DBAL's `PDOConnection`. Those tests would exit with a fatal error because of incompatible method signatures (see doctrine/dbal#3791) and until we can test against a compatible version of DBAL, there's (at least from my point of view) nothing we can do about it. Once this issue is resolved, we can revert this change.

Commits
-------

1090738 Skip Doctrine DBAL on php 8 until we have a compatible version.
craigh referenced this issue in zikula/core Jan 8, 2021
@Guite
avoid php8 during composer usage atm
32e6b59
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@morozov morozov

Labels
Connections Duplicate PDO
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@morozov @orklah