Skip to content

Commit

Permalink
avoid php8 during composer usage atm
Browse files Browse the repository at this point in the history
  • Loading branch information
@Guite
Guite committed Jan 8, 2021
1 parent 2127efa commit 32e6b59
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions .github/workflows/update-dependencies.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ jobs:
update-deps:
runs-on: ubuntu-latest
steps:
- name: Checkout sources from 3.0 branch
- name: Checkout sources from master branch
uses: actions/checkout@v2
with:
ref: master
Expand All @@ -24,14 +24,12 @@ jobs:

- name: Install dependencies
run: |
composer install
php7.4 composer install
- name: Update dependencies
#run: |
# php -dmemory_limit=10G /usr/bin/composer update
run: |
composer config --global github-oauth.github.com ${{ secrets.GITHUB_TOKEN }}
composer update
php7.4 composer update
composer config --global --auth --unset github-oauth.github.com
# see https://github.com/peter-evans/create-pull-request
Expand Down

8 comments on commit 32e6b59

@craigh
Copy link
Member

@craigh craigh commented on 32e6b59 Jan 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is using composer 2 now, right? composer 2 should work properly.

@Guite
Copy link
Member Author

@Guite Guite commented on 32e6b59 Jan 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but DBAL seems not ready yet, so the cache clear post process fails:

[php] Fatal Compile Error: Declaration of Doctrine\DBAL\Driver\PDOConnection::query() must be compatible with PDO::query(string $query, ?int $fetchMode = null, mixed ...$fetchModeArgs)

See https://github.com/zikula/core/runs/1668626100?check_suite_focus=true

@craigh
Copy link
Member

@craigh craigh commented on 32e6b59 Jan 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this only happens in the dev env. if you specify --env=prod I then I think it works.

@craigh
Copy link
Member

@craigh craigh commented on 32e6b59 Jan 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and cache:clear has nothing to do with composer - it is simply running at symfony command.

@craigh
Copy link
Member

@craigh craigh commented on 32e6b59 Jan 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see this as an example. I have errors locally when clearing the cache in the dev env also. so I just eliminated it. Although it seems to work in general use (in dev mode). Also I think the errors occurred for me before the jump to composer 2.

@Guite
Copy link
Member Author

@Guite Guite commented on 32e6b59 Jan 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

honestly I can't follow you. feel free to change update-dependencies.yml as you think it is correct 😄

@craigh
Copy link
Member

@craigh craigh commented on 32e6b59 Jan 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry - I guess I misunderstood some parts of that and went on a rabbit-trail. I think this is fixed by Doctrine/Dbal v3+

search on the error pointed to ->

but they all seem related to using php8 which this seems to fix? So what does that mean?

DBAL v3.0.0 is released. Might be worth checking to see.

@Guite
Copy link
Member Author

@Guite Guite commented on 32e6b59 Jan 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't get DBAL 3.0.0 yet because other vendors need to become compatible with it first. But good to know that a solution is going to arrive 😄

Please sign in to comment.