Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on doctrine/common #3181

Merged
merged 1 commit into from
Jun 11, 2018
Merged

Remove dependency on doctrine/common #3181

merged 1 commit into from
Jun 11, 2018

Conversation

Majkl578
Copy link
Contributor

@Majkl578 Majkl578 commented Jun 7, 2018

Q A
Type improvement
BC Break no
Fixed issues #3176

Summary

Replace doctrine/common with dependency on doctrine/cache + doctrine/event-manager.

This also drops indirect dependency on:

  • doctrine/lexer
  • doctrine/collections
  • doctrine/annotations
  • doctrine/inflector

closes #3176

@Majkl578 Majkl578 added this to the 2.8.0 milestone Jun 7, 2018
@Majkl578 Majkl578 requested review from morozov and jwage June 7, 2018 22:03
morozov
morozov reviewed Jun 7, 2018
View reviewed changes
composer.json Outdated
@@ -14,7 +14,8 @@
"require": {
"php": "^7.1",
"ext-pdo": "*",
"doctrine/common": "^2.7.1"
"doctrine/cache": "^1.0",
"doctrine/event-manager": "^1.0@dev"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we release this first?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends, leaving the decision up to you. 😛 We should definitely have 1.0.0 before DBAL 2.8 either way.

Copy link
Member

@morozov morozov Jun 7, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's a stable commit in this package's history, we should release it from there and solve other issues like doctrine/event-manager#4 later. It's better than leaving the depending package in an unstable state.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumped to stable. 👍

@jwage
Copy link
Member

jwage commented Jun 11, 2018

If this is not considered a BC break, I think we should release this in a Doctrine DBAL 1.7.x release. @Ocramius thoughts?

@morozov
Copy link
Member

morozov commented Jun 11, 2018

I have a gut feeling it should be 2.8.0 rather than 2.7.x. If it was a BC break, it would have to be 3.0.0. If it was just a patch or a bug fix, it would be 2.7.x. But it's more of an improvement and code reorganization.

@morozov
Copy link
Member

morozov commented Jun 11, 2018 •
edited
Loading

Waiting for the consensus before merging (the upgrade file specifically say the change will have happened in 2.8).

@Ocramius
Copy link
Member

If this is not considered a BC break, I think we should release this in a Doctrine DBAL 1.7.x release.
@Ocramius thoughts?

Patch releases MUST leave dependencies un-touched, because every older system MUST be able to run a composer update at any time in order to receive eventual security patches, so the constraints are very important there.

We can make this land in 2.8, but not 2.7.

@Ocramius Ocramius self-assigned this Jun 11, 2018
@Ocramius
Copy link
Member

🚢

@Ocramius Ocramius merged commit 79c732b into doctrine:master Jun 11, 2018
@Majkl578 Majkl578 deleted the drop-common-dependency branch June 11, 2018 22:43
@Majkl578 Majkl578 mentioned this pull request Jun 20, 2018
Closed
@Majkl578 Majkl578 mentioned this pull request Jul 11, 2018
Merged
@Majkl578 Majkl578 mentioned this pull request Oct 2, 2018
Open
rgrellmann added a commit to Rossmann-IT/dbal that referenced this pull request Apr 22, 2020
@rgrellmann
Merge tag 'v2.8.0' into oracle122
1b29f58 
Release v2.8.0

[![Build Status](https://travis-ci.org/doctrine/dbal.svg?branch=v2.8.0)](https://travis-ci.org/doctrine/dbal)

This is a minor release of Doctrine DBAL that aggregates over 30 fixes and improvements developed over the last 3 months.

This release includes all changes of the 2.7.x series, as well as feature additions and improvements that couldn’t land in patch releases.

**Backwards Compatibility Breaks**

This doesn't contain any intentional Backwards Compatibility (BC) breaks.

**Dependency Changes**

* The dependency on [doctrine/common](https://github.com/doctrine/common) is removed. DBAL now depends on [doctrine/cache](https://github.com/doctrine/cache) and [doctrine/event-manager](https://github.com/doctrine/event-manager) instead.

Please see details in the [UPGRADE.md](UPGRADE.md) documentation.

**Deprecations**

* The usage of binary fields whose length exceeds the maximum field size on a given platform is deprecated. Please use binary fields of a size which fits all target platforms, or use blob explicitly instead.
* The usage of DB-generated UUIDs is deprecated. Their format is inconsistent across supported platforms and therefore the feature is not portable. Use a PHP library (e.g. [ramsey/uuid](https://packagist.org/packages/ramsey/uuid)) to generate UUIDs on the application side.

**New features**

* Initial support of MySQL 8.
* Initial support of PostgreSQL 11.
* Ability to evaluate arbitrary SQL expressions via `AbstractPlatform::getDummySelectSQL()`.

**Improvements and Fixes**

* Improved support of binary fields on Oracle and IBM DB2.
* Improved SQL Server configuration capabilities via both `sqlsrv` and `pdo_sqlsrv`.
* Improved handling of `AUTOINCREMENT`ed primary keys in SQLite.
* Integration tests are run against IBM DB2 on Travis CI.
* Code coverage is collected for the Oracle platform on continuousphp.

Total issues resolved: **33**

**Deprecations:**

- [3187: Deprecate usage of binary fields whose length exceeds maximum](doctrine#3187) thanks to @morozov
- [3188: Deprecated usage of binary fields whose length exceeds the platform maximum](doctrine#3188) thanks to @morozov
- [3192: Added more information to the deprecation notice](doctrine#3192) thanks to @morozov
- [3212: Deprecated usage of DB-generated UUIDs](doctrine#3212) thanks to @morozov

**New Features:**

**Bug Fixes:**

- [3149: Introduced binary binding type to support binary parameters on Oracle](doctrine#3149) thanks to @morozov
- [3178: Fix incorrect exception thrown from SQLAnywhere16Platform](doctrine#3178) thanks to @Majkl578
- [3044: Functional test for allowing dynamic intervals in date sub/add](doctrine#3044) thanks to @AshleyDawson
- [3049: Test failures caused by invalid database connection result in fatal error](doctrine#3049) thanks to @Majkl578

**Improvements:**

- [3033: Added support for available DSN parameters for the PDOSqlsrv driver](doctrine#3033) thanks to @aashmelev
- [3128: Add MySQL 8 reserved keywords](doctrine#3128) thanks to @mlocati
- [3143: initialize sql array into platform files](doctrine#3143) thanks to @AlessandroMinoccheri
- [3173: Fix composer branch aliases](doctrine#3173) thanks to @Majkl578
- [3157: When building a limit query, zero offset without a limit should be ignored](doctrine#3157) thanks to @morozov
- [3109: Allow to specify arbitrary SQL expression in AbstractPlatform::getDummySelectSQL()](doctrine#3109) thanks to @morozov
- [3141: allow creating PRIMARY KEY AUTOINCREMENT fields for sqlite (unit tests)](doctrine#3141) thanks to @TimoBakx
- [3180: Import simplified version of Common\Util\Debug for var dumping purposes](doctrine#3180) thanks to @Majkl578

**Documentation Improvements:**

- [3117: Added badges for the develop branch in README](doctrine#3117) thanks to @morozov
- [3125: Upgrading docs](doctrine#3125) thanks to @jwage
- [3144: added improvement type into pull request template](doctrine#3144) thanks to @AlessandroMinoccheri

**Code Quality Improvements:**

- [3025: Added PHPStan, apply changes for level 3](doctrine#3025) thanks to @Majkl578
- [3200: Php Inspections (EA Ultimate): minor code tweaks](doctrine#3200) thanks to @kalessil
- [3204: Fix typo in AbstractPlatform](doctrine#3204) thanks to @Majkl578
- [3205: Ignore OCI-* classes in static analysis (no stubs)](doctrine#3205) thanks to @Majkl578

**Continuous Integration Improvements:**

- [3102: Use newer PHPUnit to prevent crashes on failures](doctrine#3102) thanks to @Majkl578
- [3112: Removed hard-coded configuration filenames from the test runner](doctrine#3112) thanks to @morozov
- [3133: Travis DB2](doctrine#3133) thanks to @Majkl578, @morozov
- [3135: AppVeyor tweaks, retry coverage upload on failure](doctrine#3135) thanks to @Majkl578
- [3137: Workaround for the inability to use a post-PHPUnit script on ContinuousPHP](doctrine#3137) thanks to @morozov
- [3151: MSSQL DLL 5.2.0 has been released.](doctrine#3151) thanks to @photodude
- [3160: Test against Postgres 11](doctrine#3160) thanks to @Majkl578

**Dependencies**

- [3193: DBAL 2.8 needs Common 2.9](doctrine#3193) thanks to @Majkl578
- [3176: Eliminate dependency on doctrine/common](doctrine#3176) thanks to @Majkl578
- [3181: Remove dependency on doctrine/common](doctrine#3181) thanks to @Majkl578

# gpg: Signature made Fri Jul 13 06:02:10 2018
# gpg:                using RSA key 374EADAF543AE995
# gpg: Can't check signature: public key not found

# Conflicts:
#	.gitignore
#	README.md
#	lib/Doctrine/DBAL/Version.php
#	tests/appveyor/mssql.sql2008r2sp2.sqlsrv.appveyor.xml
#	tests/appveyor/mssql.sql2012sp1.sqlsrv.appveyor.xml
#	tests/appveyor/mssql.sql2017.pdo_sqlsrv.appveyor.xml
#	tests/appveyor/mssql.sql2017.sqlsrv.appveyor.xml
#	tests/travis/mariadb.mysqli.travis.xml
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@morozov morozov morozov approved these changes

@Ocramius Ocramius Ocramius approved these changes

@jwage jwage Awaiting requested review from jwage

Assignees

@Ocramius Ocramius

Labels
Improvement
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

Eliminate dependency on doctrine/common
4 participants
@Majkl578 @jwage @morozov @Ocramius