Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed support for DB-generated UUIDs #3211

Merged
merged 1 commit into from
Aug 2, 2018
Merged

Removed support for DB-generated UUIDs #3211

merged 1 commit into from
Aug 2, 2018

Conversation

morozov
Copy link
Member

@morozov morozov commented Jul 11, 2018

Q A
Type improvement
BC Break yes
Fixed issues #3167

stloyd
stloyd suggested changes Jul 11, 2018
View reviewed changes
docs/en/reference/sharding.rst Outdated
@@ -100,11 +100,12 @@ platforms:

<?php
use Doctrine\DBAL\DriverManager;
use Rhumsaa\Uuid\Uuid;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you suggest to use ramsey/uuid library I guess those namespaces should be: Ramsey\Uuid\Uuid

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @stloyd.

Ocramius
Ocramius approved these changes Jul 11, 2018
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting for more opinions by @doctrine/doctrinecore before FIRING ZEH MISSILES!

@morozov morozov self-assigned this Jul 11, 2018
@morozov morozov added this to the 3.0.0 milestone Jul 11, 2018
Majkl578
Majkl578 reviewed Jul 11, 2018
View reviewed changes
Copy link
Contributor

@Majkl578 Majkl578 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be dropped in ORM first. Otherwise 👍

@RusAlex
Copy link

RusAlex commented Jul 12, 2018

Hi, mates. Sorry it's not any link to issue. Where can I read , why this changes are needed ?

@Majkl578
Copy link
Contributor

@RusAlex See #3167.

@Majkl578 Majkl578 mentioned this pull request Aug 2, 2018
Merged
Majkl578
Majkl578 approved these changes Aug 2, 2018
View reviewed changes
Copy link
Contributor

@Majkl578 Majkl578 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to go after rebase. 👌

@morozov morozov merged commit a5109cd into doctrine:develop Aug 2, 2018
@morozov morozov deleted the issues/3167 branch August 2, 2018 19:20
@Majkl578 Majkl578 mentioned this pull request Aug 3, 2018
Closed
This was referenced Aug 5, 2018
Closed
Closed
Closed
morozov added a commit that referenced this pull request Aug 7, 2018
@morozov
Merge pull request #3211 from morozov/issues/3167
89fbe15 
Removed support for DB-generated UUIDs
morozov added a commit that referenced this pull request Sep 29, 2018
@morozov
Merge pull request #3211 from morozov/issues/3167
80827d3 
Removed support for DB-generated UUIDs
morozov added a commit that referenced this pull request Oct 7, 2018
@morozov
Merge pull request #3211 from morozov/issues/3167
cecb2e4 
Removed support for DB-generated UUIDs
morozov added a commit that referenced this pull request Oct 7, 2018
@morozov
Merge pull request #3211 from morozov/issues/3167
cecf3ac 
Removed support for DB-generated UUIDs
morozov added a commit that referenced this pull request Nov 14, 2018
@morozov
Merge pull request #3211 from morozov/issues/3167
d860519 
Removed support for DB-generated UUIDs
morozov added a commit that referenced this pull request Nov 14, 2018
@morozov
Merge pull request #3211 from morozov/issues/3167
727e4f2 
Removed support for DB-generated UUIDs
morozov added a commit that referenced this pull request Nov 25, 2018
@morozov
Merge pull request #3211 from morozov/issues/3167
03ccace 
Removed support for DB-generated UUIDs
morozov added a commit that referenced this pull request Dec 6, 2018
@morozov
Merge pull request #3211 from morozov/issues/3167
7bb1ea7 
Removed support for DB-generated UUIDs
morozov added a commit that referenced this pull request Jan 20, 2019
@morozov
Merge pull request #3211 from morozov/issues/3167
a4b7bb4 
Removed support for DB-generated UUIDs
morozov added a commit to morozov/dbal that referenced this pull request Feb 6, 2019
@morozov
Merge pull request doctrine#3211 from morozov/issues/3167
09d30cf 
Removed support for DB-generated UUIDs
morozov added a commit to morozov/dbal that referenced this pull request Feb 6, 2019
@morozov
Merge pull request doctrine#3211 from morozov/issues/3167
d5b98f7 
Removed support for DB-generated UUIDs
morozov added a commit that referenced this pull request Feb 7, 2019
@morozov
Merge pull request #3211 from morozov/issues/3167
aba165b 
Removed support for DB-generated UUIDs
morozov added a commit that referenced this pull request Feb 20, 2019
@morozov
Merge pull request #3211 from morozov/issues/3167
1a276a8 
Removed support for DB-generated UUIDs
morozov added a commit that referenced this pull request Feb 22, 2019
@morozov
Merge pull request #3211 from morozov/issues/3167
a68ec00 
Removed support for DB-generated UUIDs
morozov added a commit that referenced this pull request Mar 15, 2019
@morozov
Merge pull request #3211 from morozov/issues/3167
c17a7c9 
Removed support for DB-generated UUIDs
morozov added a commit that referenced this pull request Mar 15, 2019
@morozov
Merge pull request #3211 from morozov/issues/3167
273e2a2 
Removed support for DB-generated UUIDs
morozov added a commit that referenced this pull request Mar 18, 2019
@morozov
Merge pull request #3211 from morozov/issues/3167
e98f3aa 
Removed support for DB-generated UUIDs
morozov added a commit that referenced this pull request Apr 16, 2019
@morozov
Merge pull request #3211 from morozov/issues/3167
3a9e527 
Removed support for DB-generated UUIDs
morozov added a commit that referenced this pull request May 6, 2019
@morozov
Merge pull request #3211 from morozov/issues/3167
fbda20a 
Removed support for DB-generated UUIDs
morozov added a commit that referenced this pull request May 23, 2019
@morozov
Merge pull request #3211 from morozov/issues/3167
51e7956 
Removed support for DB-generated UUIDs
morozov added a commit to morozov/dbal that referenced this pull request May 31, 2019
@morozov
Merge pull request doctrine#3211 from morozov/issues/3167
cd5f598 
Removed support for DB-generated UUIDs
morozov added a commit that referenced this pull request Jun 13, 2019
@morozov
Merge pull request #3211 from morozov/issues/3167
7704b23 
Removed support for DB-generated UUIDs
morozov added a commit that referenced this pull request Jun 27, 2019
@morozov
Merge pull request #3211 from morozov/issues/3167
91c4f8a 
Removed support for DB-generated UUIDs
morozov added a commit to morozov/dbal that referenced this pull request Aug 26, 2019
@morozov
Merge pull request doctrine#3211 from morozov/issues/3167
4621e0b 
Removed support for DB-generated UUIDs
morozov added a commit that referenced this pull request Nov 2, 2019
@morozov
Merge pull request #3211 from morozov/issues/3167
a490dec 
Removed support for DB-generated UUIDs
@morozov morozov mentioned this pull request Jun 17, 2020
Merged
2 tasks
@morozov morozov modified the milestones: 4.0.0, 3.0.0 Jun 17, 2020
This was referenced Aug 7, 2021
Closed
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stloyd stloyd stloyd requested changes

@malarzm malarzm malarzm approved these changes

@Ocramius Ocramius Ocramius approved these changes

@Majkl578 Majkl578 Majkl578 approved these changes

Assignees

@morozov morozov

Labels
BC Break Platforms
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@morozov @RusAlex @Majkl578 @stloyd @Ocramius @malarzm