Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport removal of deprecated APIs from develop #4082

Merged
merged 21 commits into from
Jun 17, 2020

Conversation

morozov
Copy link
Member

@morozov morozov commented Jun 17, 2020

Q A
Type improvement
BC Break yes

This is a backport of the following pull requests originally merged into develop: #3211, #3257, #3518, #3553, #3568, #3577, #3579, #3584, #3594, #3606.

TODO:

  • Once this is merged, most of the pull requests above should be moved from the 4.0.0 milestone to 3.0.0. Some of them contain more than removal of the deprecated functionality and should stay in 4.0.0.
  • During the merge up, the corresponding entries should be removed from 4.0.0 section of UPGRADE.md.

@greg0ire
Copy link
Member

So develop was just removed?

greg0ire
greg0ire previously approved these changes Jun 17, 2020
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this has already been reviewed and merged

@morozov
Copy link
Member Author

morozov commented Jun 17, 2020

So develop was just removed?

It was renamed to master.

@morozov
Copy link
Member Author

morozov commented Jun 17, 2020

A rebase was needed to address a conflict with the changes from #4083.

@morozov morozov requested a review from greg0ire June 17, 2020 18:24
@morozov morozov merged commit 61a06a5 into doctrine:3.0.x Jun 17, 2020
@morozov morozov deleted the remove-deprecated branch June 17, 2020 20:14
@morozov morozov self-assigned this Jun 17, 2020
@greg0ire greg0ire mentioned this pull request Aug 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants