Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed some unused code bits #3594

Merged
merged 1 commit into from
Jun 6, 2019
Merged

Conversation

morozov
Copy link
Member

@morozov morozov commented Jun 6, 2019

Q A
Type improvement
BC Break yes
  1. OCI8Statement::$_PARAM. Was never used since its introduction.
  2. AbstractPlatform::_getAlterTableIndexForeignKeySQL() is unused since [DBAL-1016] Fix explicitly quoted table identifiers in ALTER TABLE statements #700 (v2.5.0).
  3. The $type variable in SQLAzureShardManager::splitFederation() is unused since Connection::quote() can only quote strings #3488.

TODO:

@morozov morozov merged commit e0b4180 into doctrine:develop Jun 6, 2019
@morozov morozov deleted the remove-unused branch June 6, 2019 14:04
@morozov morozov self-assigned this Jun 6, 2019
morozov added a commit that referenced this pull request Jun 13, 2019
Removed some unused code bits
morozov added a commit that referenced this pull request Jun 27, 2019
Removed some unused code bits
morozov added a commit that referenced this pull request Jun 27, 2019
Removed some unused code bits
morozov added a commit that referenced this pull request Jun 27, 2019
Removed some unused code bits
morozov added a commit to morozov/dbal that referenced this pull request Aug 26, 2019
morozov added a commit to morozov/dbal that referenced this pull request Aug 26, 2019
morozov added a commit to morozov/dbal that referenced this pull request Aug 26, 2019
morozov added a commit to morozov/dbal that referenced this pull request Aug 27, 2019
morozov added a commit that referenced this pull request Nov 2, 2019
Removed some unused code bits
@morozov morozov modified the milestones: 4.0.0, 3.0.0 Jun 17, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants