Fix double quote used wrongly for literal value in SqliteSchemaManager #6325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Out of curiosity, does anyone have any idea why php does that and if it can be potentionally disabled - to improve testing quality and reject such unwanted syntax in general. |
derrabus
approved these changes
Mar 5, 2024
|
Thank you! |
|
@derrabus thank you, may I ask you if you have any idea about #6325 (comment)? |
|
You may and my answer is "no". 🙂 |
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Mar 21, 2024
* 3.8.x: Add MariaDB 11.3 to the test matrix (doctrine#6342) Spell which properly Fix double quote used wrongly for literal value in SqliteSchemaManager (doctrine#6325)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It seems PHP SQLite drivers allows
"to be used to escape literal values, but natively such syntax produces an sqlite parse error [1].I have discovered this when analysing SQLite log, it is otherwise tested.
I checked all other
"in SQLite platform and manager and all of them seems correct otherwise.[1] https://dbfiddle.uk/KQAGp9Ea (notice the 2nd query is the same, but uses
"instead of')