-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Documentation] Adding "versionadded" #6336
Conversation
Page: https://www.doctrine-project.org/projects/doctrine-dbal/en/4.0/reference/types.html#bigint The `int`-mapping needs to be added at https://www.doctrine-project.org/projects/doctrine-orm/en/3.1/reference/basic-mapping.html#doctrine-mapping-types too! What is the right version information? Is it only working if you have DBAL 4 **and** ORM 3?
To my knowledge, we're not using this kind of block in DBAL's documentation yet. Should we start doing that? If so, what would be our policy for eventually removing these blocks? cc @greg0ire @SenseException
Yes, PR welcome. I wonder if we should additionally link to the DBAL documentation here, for people who want to dig a little deeper into how the different types are mapped to the database.
DBAL 4. The ORM itself has no opinion on type conversions and leverages the DBAL type system for that. |
If you ask me, I'd completely delete https://www.doctrine-project.org/projects/doctrine-orm/en/3.1/reference/basic-mapping.html#doctrine-mapping-types and ONLY link to https://www.doctrine-project.org/projects/doctrine-dbal/en/4.0/reference/types.html#reference , since it mainly duplicates what is said there. |
I'm OK with adding |
... in favor of https://www.doctrine-project.org/projects/doctrine-dbal/en/3.8/reference/types.html#reference Page: https://www.doctrine-project.org/projects/doctrine-orm/en/2.19/reference/basic-mapping.html#doctrine-mapping-types As announced in doctrine/dbal#6336 (comment) , the goal is to remove this duplicated type information from ORM and replace it with a link to DBAL. In doctrine/dbal#6341 , I'm adding any detail which I'm deleting here to the DBAL.
... in favor of https://www.doctrine-project.org/projects/doctrine-dbal/en/3.8/reference/types.html#reference Page: https://www.doctrine-project.org/projects/doctrine-orm/en/2.19/reference/basic-mapping.html#doctrine-mapping-types As announced in doctrine/dbal#6336 (comment) , the goal is to remove this duplicated type information from ORM and replace it with a link to DBAL. In doctrine/dbal#6341 , I'm adding any detail which I'm deleting here to the DBAL.
... in favor of https://www.doctrine-project.org/projects/doctrine-dbal/en/3.8/reference/types.html#reference Page: https://www.doctrine-project.org/projects/doctrine-orm/en/2.19/reference/basic-mapping.html#doctrine-mapping-types As announced in doctrine/dbal#6336 (comment) , the goal is to remove this duplicated type information from ORM and replace it with a link to DBAL. In doctrine/dbal#6341 , I'm adding any detail which I'm deleting here to the DBAL.
Summary
Page: https://www.doctrine-project.org/projects/doctrine-dbal/en/4.0/reference/types.html#bigint
The
int
-mapping needs to be added at https://www.doctrine-project.org/projects/doctrine-orm/en/3.1/reference/basic-mapping.html#doctrine-mapping-types too!What is the right version information? Is it only working if you have DBAL 4 and ORM 3?