Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Adding "versionadded" #6336

Merged
merged 1 commit into from
Mar 19, 2024
Merged

[Documentation] Adding "versionadded" #6336

merged 1 commit into from
Mar 19, 2024

Conversation

ThomasLandauer
Copy link
Contributor

Q A
Type improvement
Fixed issues none

Summary

Page: https://www.doctrine-project.org/projects/doctrine-dbal/en/4.0/reference/types.html#bigint

The int-mapping needs to be added at https://www.doctrine-project.org/projects/doctrine-orm/en/3.1/reference/basic-mapping.html#doctrine-mapping-types too!

What is the right version information? Is it only working if you have DBAL 4 and ORM 3?

@derrabus
Copy link
Member

To my knowledge, we're not using this kind of block in DBAL's documentation yet. Should we start doing that? If so, what would be our policy for eventually removing these blocks? cc @greg0ire @SenseException

The int-mapping needs to be added at https://www.doctrine-project.org/projects/doctrine-orm/en/3.1/reference/basic-mapping.html#doctrine-mapping-types too!

Yes, PR welcome.

I wonder if we should additionally link to the DBAL documentation here, for people who want to dig a little deeper into how the different types are mapped to the database.

What is the right version information? Is it only working if you have DBAL 4 and ORM 3?

DBAL 4. The ORM itself has no opinion on type conversions and leverages the DBAL type system for that.

@ThomasLandauer
Copy link
Contributor Author

@greg0ire
Copy link
Member

I'm OK with adding versionadded blocks. Let's say we'd remove them when lower versions are no longer maintained?

@derrabus derrabus added this to the 4.0.2 milestone Mar 19, 2024
@derrabus derrabus merged commit bd7e79f into doctrine:4.0.x Mar 19, 2024
@ThomasLandauer ThomasLandauer deleted the patch-1 branch March 19, 2024 10:07
ThomasLandauer added a commit to ThomasLandauer/orm that referenced this pull request Mar 20, 2024
... in favor of https://www.doctrine-project.org/projects/doctrine-dbal/en/3.8/reference/types.html#reference

Page: https://www.doctrine-project.org/projects/doctrine-orm/en/2.19/reference/basic-mapping.html#doctrine-mapping-types

As announced in doctrine/dbal#6336 (comment) , the goal is to remove this duplicated type information from ORM and replace it with a link to DBAL.

In doctrine/dbal#6341 , I'm adding any detail which I'm deleting here to the DBAL.
ThomasLandauer added a commit to ThomasLandauer/orm that referenced this pull request Mar 20, 2024
... in favor of https://www.doctrine-project.org/projects/doctrine-dbal/en/3.8/reference/types.html#reference

Page: https://www.doctrine-project.org/projects/doctrine-orm/en/2.19/reference/basic-mapping.html#doctrine-mapping-types

As announced in doctrine/dbal#6336 (comment) , the goal is to remove this duplicated type information from ORM and replace it with a link to DBAL.

In doctrine/dbal#6341 , I'm adding any detail which I'm deleting here to the DBAL.
SenseException pushed a commit to doctrine/orm that referenced this pull request Mar 20, 2024
derrabus added a commit that referenced this pull request Mar 21, 2024
* 4.0.x:
  Add MariaDB 11.3 to the test matrix (#6342)
  [Documentation] Fixing markup (#6340)
  Remove older versions from the docs
  [Documentation] Adding "versionadded" (#6336)
  Update UPGRADE.md
  Spell which properly
  Fix double quote used wrongly for literal value in SqliteSchemaManager (#6325)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants