Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try removing quotes #6501

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Try removing quotes #6501

merged 1 commit into from
Aug 15, 2024

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire commented Aug 15, 2024

I have been told it could fix the issue we have with Codecov. Let us try the suggestion before reporting a new issue.

@derrabus
Copy link
Member

If that works: Please target 3.9.x.

@greg0ire
Copy link
Member Author

OK. FTR I'm not very hopeful it will fix the issue, but I've been wrong before.

@greg0ire
Copy link
Member Author

greg0ire commented Aug 15, 2024

🤯 🤯 🤯 why does it work?!?

I'm rebasing.

I have been told it could fix the issue we have with Codecov. Let us try
the suggestion before reporting a new issue.
@greg0ire greg0ire force-pushed the try-removing-quotes branch from 07fbe40 to 44c5169 Compare August 15, 2024 14:22
@greg0ire greg0ire changed the base branch from 4.1.x to 3.9.x August 15, 2024 14:22
@greg0ire greg0ire marked this pull request as ready for review August 15, 2024 14:22
@derrabus derrabus added the CI label Aug 15, 2024
@derrabus derrabus added this to the 3.9.1 milestone Aug 15, 2024
@derrabus derrabus merged commit a6707bf into doctrine:3.9.x Aug 15, 2024
75 checks passed
derrabus added a commit that referenced this pull request Aug 15, 2024
* 3.9.x:
  Try removing quotes (#6501)
derrabus added a commit that referenced this pull request Aug 15, 2024
* 4.2.x:
  Try removing quotes (#6501)
@greg0ire greg0ire deleted the try-removing-quotes branch August 15, 2024 18:00
@greg0ire
Copy link
Member Author

greg0ire commented Aug 17, 2024

It seems that it still fails, it's just that it fails randomly: https://github.com/doctrine/dbal/actions/runs/10426300024/job/28890873426?pr=5897

I will open another ticket on Codecov

EDIT: codecov/codecov-action#1548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants