A whole slew of changes for 3.0.x! See the summary.

[TomHAnderson]

Q	A
Type	improvement
BC Break	no

Summary

• Updated box to 3.9.1
• Allow for PDO namespace changes after DBAL 2.11
• Reformatted composer.json and removed config platform of 7.2
• Fixed at() calls in tests
• Allow organize_migrations to be set to false with a new 'none' value
• Add composer-normalize

Please note the branch name is now out of sync with this PR.

[stof]

is it expected to change the indentation of composer.json ?

[TomHAnderson]

I ran composer.json through the npm package json because it was formatted with multiple properties per line. That was intentional

[goetas]

I guess we should use the static implementation, so self

[TomHAnderson]

That doesn't play well with phpstan

[TomHAnderson]

More info: method_exists cannot take self as the first parameter. So if you use $this for method_exists then use self for assertMatchesRegularExpression phpstan has a problem with that.

[greg0ire]

What about using the class name (can't use $this::class for now since it's PHP 8 but TestCase::class should do the trick)?

[TomHAnderson]

Nope. You see, phpstan is clearing (for lack of a better term) the use of $this after the method_exists function and seeing that it won't be called passes.

        if (method_exists(TestCase::class, 'assertMatchesRegularExpression')) {
            self::assertMatchesRegularExpression('/^Foo\\\\Version[0-9]{14}$/', $fqcn);

Results in

 ------ ----------------------------------------------------------------------------------------------------------------------------------
  Line   tests/Doctrine/Migrations/Tests/Generator/ClassNameGeneratorTest.php
 ------ ----------------------------------------------------------------------------------------------------------------------------------
  20     Call to an undefined static method Doctrine\Migrations\Tests\Generator\ClassNameGeneratorTest::assertMatchesRegularExpression().
 ------ ----------------------------------------------------------------------------------------------------------------------------------

[TomHAnderson]

This repo needs to be set to a minimum PHP version of 7.3 in a future version so we can remove the check for the DBAL version which is deprecated and remove the logic for using using a regex assertion.

[goetas]

looks good! thanks a lot @TomHAnderson