Use composer v1 when running the low deps CI jobs #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goetas
force-pushed
the
composer-v1-compat
branch
from
69c41c0 to
c8cc9cf
Compare
|
🤔 maybe we should do that only for the |
greg0ire
reviewed
Nov 28, 2020
goetas
force-pushed
the
composer-v1-compat
branch
from
dd5f17d to
40af6ca
Compare
|
rebased and reworded the commit |
goetas
changed the title
greg0ire
approved these changes
Nov 28, 2020
|
Thanks! Not labelling as "bug" since it's a dev dependency, the only people impacted are contributors. Labelling as CI because it's a good thing to check for I suppose. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #1079, some dev deps were compatible only with composer v1, with this we run the builds using both composer versions