Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Move tip admonition from doctrine/doctrine-website #186

Merged
merged 3 commits into from
Dec 1, 2022
Merged

[FEATURE] Move tip admonition from doctrine/doctrine-website #186

merged 3 commits into from
Dec 1, 2022

Conversation

linawolf
Copy link
Collaborator

references #6

@greg0ire greg0ire added the Enhancement New feature or request label Nov 30, 2022
linawolf and others added 2 commits November 30, 2022 14:29
@linawolf @greg0ire
Update lib/Directives/Admonition.php
beab47d 
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr>
@linawolf
[FEATURE] Add test for multiline tip
d526fae
@greg0ire greg0ire merged commit 177fca5 into doctrine:0.5.x Dec 1, 2022
@greg0ire
Copy link
Member

greg0ire commented Dec 1, 2022

Thanks @linawolf !

@greg0ire greg0ire added this to the 0.5.3 milestone Dec 1, 2022
@github-actions github-actions bot mentioned this pull request Dec 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SenseException SenseException SenseException approved these changes

@greg0ire greg0ire greg0ire approved these changes

@jwage jwage Awaiting requested review from jwage

Assignees
No one assigned
Labels
Enhancement New feature or request
Projects
None yet
Milestone
0.5.3
Development

Successfully merging this pull request may close these issues.
3 participants
@linawolf @greg0ire @SenseException