Merge release 0.5.3 into 0.6.x #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Remove duplicate utf8-encoding in multiline table content resolves #177
Allow block of comments
[BUGFIX] Fix UTf-8 encoding in tables
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr>
[FEATURE] Allow overlined titles
Adjusting the whitespace in HTML files to what our renderer outputs is tiresome. And nice formating of the html is really not in the scope of this project. Multiple whitespaces are ignored in HTML anyway. So I would suggest to trim the lines before comparing instead of rtrimming them. Adjusted 2 Tests to demonstrate this is wokring. A follow up which compares the HTML structure in a more logical way would be nice but having this already makes testing much easier without giving up acuracy
[TASK] Compare lines in HTML functional tests trimmed
[BUGFIX] replace deprecated PHP unit method
greg0ire
approved these changes
Jan 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes for 0.5.3
0.5.x bugfix release (patch)
0.5.3
Total issues resolved: 0
Total pull requests resolved: 12
Total contributors: 3
220: Allow block of comments thanks to @nikophil
217: [BUGFIX] Fix UTf-8 encoding in tables thanks to @linawolf
198: [TASK] Create Functional Tests for Toctrees thanks to @linawolf
196: Better dataprovider phpdoc thanks to @greg0ire
195: Upgrade coding standard library thanks to @greg0ire
194: Upgrade phpstan thanks to @greg0ire
190: Workflow maintenance thanks to @greg0ire
Enhancement
Documentation
Bug
htmlspecialchars()flags thanks to @greg0ire