Upgrade phpstan #194
Merged
Upgrade phpstan #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They should have been removed in 655bd01
This closure is supposed to return a string, not an integer.
greg0ire
force-pushed
the
upgrade-phpstan
branch
from
bcbf5ae
to
79c3eec
Compare
Comment on lines
-135
to
-143
| public function getParseQueue(): ParseQueue | ||
| { | ||
| if ($this->parseQueue === null) { | ||
| throw new LogicException('The ParseQueue is not set until after the build is complete'); | ||
| } | ||
|
|
||
| return $this->parseQueue; | ||
| } | ||
|
|
There was a problem hiding this comment.
Removing a public method from a patch version? What's the connection to PHPStan?
There was a problem hiding this comment.
parseQueue is never ever written to, the class is final and that property private, and that method is unused. It should have been removed in 655bd01
SenseException
approved these changes
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.