Hamurger and progress bar implementation #459
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
✅ Deploy Preview for arcticdelights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Please merge my pull request. I have resolved the conflicts. |
|
Kindly resolve conflicts. |
|
I have successfully resolved all the conflicts |
|
I think there are still some conflicts in index.html |
dohinafs
requested changes
Oct 14, 2024
There was a problem hiding this comment.
Kindly fix the following issues:
- In light mode, the text color is almost unreadable.
- We're unable to see the links after blogs. The scroll bar scrolls down the website below the hamburger menu as indicated by the progress bar above. But I can't scroll down the menu to see my orders and contact us page.
- If possible, showcase the cart, wishlist and signup options as we're currently unable to see them as there is no scroll for the menu.
|
Kindly resolve conflicts. |
ArcticDelights.-.Google.Chrome.2024-10-17.21-55-10.mp4i have done the changes that mentioned above also solved all the conflicts. |
|
Please merge |
srishti023
added a commit
to srishti023/Open-source-Practice
that referenced
this pull request
Nov 9, 2024
This is the PR i have raised and it's not been merged and it's level 3 PR. could you review and merge it! dohinaf/basic-icecream-website#459
|
This PR has been merged by the GSSoC team Don't add labels to it now. Close this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#385
Dear @dohinafs ,
I hope this message finds you well. I wanted to share that I have successfully implemented a hamburger menu for small screen sizes and a progress bar the project.
If you have any suggestions for further improvements or areas I should focus on next, please let me know.
Thank you!
Before:
NO HAMBURGER AND PROGRESS BAR
After:
HAMBURGER AND PROGRESS BAR