Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to next tag for @dojo deps #80

Merged
merged 2 commits into from
May 23, 2017
Merged

Conversation

agubler
Copy link
Member

@agubler agubler commented May 19, 2017

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:

Related to the proposed process change for managing pre-release beta and rc release sets

Related to dojo/meta#183

Copy link
Contributor

@rishson rishson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is cli on beta1 rather than next?

@dylans dylans added this to the 2017.05 milestone May 19, 2017
dylans
dylans previously requested changes May 19, 2017
Copy link
Member

@dylans dylans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually take that back, is beta1 intentional or did you mean next for cli?

@codecov
Copy link

codecov bot commented May 23, 2017

Codecov Report

Merging #80 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #80   +/-   ##
=======================================
  Coverage   94.93%   94.93%           
=======================================
  Files           9        9           
  Lines          79       79           
  Branches        3        3           
=======================================
  Hits           75       75           
  Misses          2        2           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2506b8...b8612e5. Read the comment docs.

@agubler
Copy link
Member Author

agubler commented May 23, 2017

@dylan it's intentional and as a result of having circular deps 😫

but this is a dev dependency and cli's dependency on create-app is not so I think that this is better way of doing the dependencies until we resolve that.

@agubler
Copy link
Member Author

agubler commented May 23, 2017

@rishson please see comment to @dylans above

@agubler agubler dismissed dylans’s stale review May 23, 2017 10:39

Comment has been responded to regarding beta1 versus next for @dojo/cli

@agubler agubler merged commit 34865e7 into dojo:master May 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants