Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change pre-release (beta, rc) publishing strategy #183

Closed
12 of 13 tasks
agubler opened this issue May 18, 2017 · 7 comments
Closed
12 of 13 tasks

Change pre-release (beta, rc) publishing strategy #183

agubler opened this issue May 18, 2017 · 7 comments
Assignees
Milestone

Comments

@agubler
Copy link
Member

agubler commented May 18, 2017

The beta1 period has allowed us to learn about how we should publish our pre-release packages and highlighted that what we have right now isn’t ideal. As continually publishing to beta1 is not manageable and doesn’t give us (or the community) the safety that tags are supposed to give us (as beta is basically a moving target).

The proposal is to stop publishing to beta1 now so it will become the “finished” beta1 release-set. From now until we are ready to cut beta2 we will publish to next with all of our packages depending on the next tag. At the point in time when we are ready to tag the beta2 release-set we’ll branch from master, update the dependencies (to beta2), publish (in dependency order, has upwards) and tag the final versions to beta2 and latest. We will repeat this process for our future beta and rc releases. This means that pre-release tags will always point to the end of the phase, latest will always point to the latest pre-release tag’s version (so that npm install @dojo/widget-core installs the latest “stable” version) and then next will effectively be master/development.

Nothing really will change for our internal development, just need to produce a first release of the -beta2 suffix and tag it against next for all the packages (updating the package.jsons also).

Todo:

For each dependency, in order:

  1. Update dependencies to point to next tag
  2. Release/publish first 2.0.0-beta2 version for next tag

Ensure all packages latest and beta1 tags point to the same version.

  • dojo/loader
  • dojo/has
  • dojo/shim
  • dojo/interfaces
  • dojo/core
  • dojo/routing
  • dojo/i18n
  • dojo/widgets
  • dojo/widget-core
  • dojo/cli
  • dojo/cli-build
  • dojo/cli-test-intern
  • dojo/cli-create-app
@dylans
Copy link
Member

dylans commented May 19, 2017

Should https://github.com/dojo/cli-export-project also be on this list? (and really any other packages like https://github.com/dojo/dgrid/ that rely on beta1 but are not beta1 themselves)?

@agubler
Copy link
Member Author

agubler commented May 26, 2017

@dylans It's a good question, dgrid can be updated to next if we want it to benefit from the bleeding edge changes in widget-core but equally we can stay on the beta1 tag if we want to choose when to take in the changes (some that would be breaking).

@agubler
Copy link
Member Author

agubler commented May 26, 2017

Same applies for @dojo/widgets, but I did create a pull request for widgets.

@eheasley eheasley modified the milestones: 2017.05, 2017.06 Jun 6, 2017
@eheasley eheasley added beta3 and removed beta2 labels Jun 6, 2017
@dylans dylans modified the milestones: 2017.06, 2017.07 Jul 4, 2017
@dylans dylans removed this from the 2017.06 milestone Jul 4, 2017
@kitsonk
Copy link
Member

kitsonk commented Jul 27, 2017

We have pretty much resolved this right? Or at least I believe I understand the strategy. Do we want to just hold this open until we cut beta2?

@agubler
Copy link
Member Author

agubler commented Jul 27, 2017

@kitsonk I'm happy for this to be closed if others are also.

@dylans dylans modified the milestones: 2017.07, 2017.08 Jul 29, 2017
@kitsonk kitsonk modified the milestones: 2017.08, 2017.09 Sep 4, 2017
@jason0x43
Copy link
Member

Just throwing this out there... I think we should avoid using dist tags as dependencies since they 1) cause npm to emit spurious warnings, and 2) they break the versioning contract (this is especially problematic with 'next', which could point to different major versions over time).

@kitsonk
Copy link
Member

kitsonk commented Oct 9, 2017

We have a new strategy that we used for beta3. This issue is effectively closed. We should open any follow up actions required as a new issue.

@kitsonk kitsonk closed this as completed Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants