fix: lock submodule #243
fix: lock submodule #243
Conversation
WalkthroughThe recent updates involve synchronizing the project with a new commit hash for a subproject, which may include various enhancements and bug fixes. Additionally, the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
examples/react/react-app/src/App.tsx (1)
24-28: Update all references to the new model names.The code changes in
examples/react/react-app/src/App.tsxhave introduced new model names with the "dojo_starter-" prefix. However, there are still many occurrences of the old model names (Position,Moves,DirectionsAvailable) across the codebase that need to be updated to match the new names.Files and lines with old model names:
packages/state/src/recs/index.ts: Line(s) with "Position"packages/react/src/useQuerySync.ts: Line(s) with "Position", "Moves", "DirectionsAvailable"examples/vue/vue-app/src/utils/index.ts: Line(s) with "Position"examples/vue/vue-app/src/App.vue: Multiple lines with "Position", "Moves"examples/vue/vue-app/src/dojo/createSystemCalls.ts: Multiple lines with "Position", "Moves"examples/vue/vue-app/src/dojo/createClientComponents.ts: Line(s) with "Position", "Moves"examples/vue/vue-app/src/dojo/generated/contractComponents.ts: Line(s) with "DirectionsAvailable"examples/node/torii-bot/src/index.ts: Line(s) with "Moves"examples/node/torii-bot/src/queries/getMoves.ts: Multiple lines with "Moves"examples/node/torii-bot/src/generated/graphql.ts: Multiple lines with "Moves", "Position"examples/node/torii-bot/src/commands/getMoves.ts: Multiple lines with "Moves"examples/react/react-app/src/utils/index.ts: Line(s) with "Position"examples/react/react-pwa-app/src/dojo/createSystemCalls.ts: Multiple lines with "Position", "Moves"examples/react/react-pwa-app/src/dojo/createClientComponents.ts: Line(s) with "Position", "Moves"examples/react/react-app/src/dojo/createSystemCalls.ts: Multiple lines with "Position", "Moves"examples/react/react-app/src/dojo/createClientComponents.ts: Line(s) with "Position", "Moves"examples/react/react-pwa-app/src/App.tsx: Multiple lines with "Position", "Moves"examples/react/react-threejs/src/utils.ts: Line(s) with "Position"examples/react/react-threejs/src/dojo/createSystemCalls.ts: Multiple lines with "Position", "Moves"examples/react/react-threejs/src/dojo/createClientComponents.ts: Line(s) with "Position", "Moves"examples/react/react-threejs/src/gameComponents/UIContainer.tsx: Line(s) with "Moves"examples/react/react-threejs/src/gameComponents/Three.tsx: Line(s) with "Position"examples/react/react-threejs/src/gameComponents/Players.tsx: Line(s) with "Position"examples/react/react-threejs/src/gameComponents/Player.tsx: Multiple lines with "Position"examples/react/react-phaser-example/src/dojo/generated/contractComponents.ts: Line(s) with "DirectionsAvailable", "Moves", "Position"Please update all references to ensure consistency throughout the codebase.
Analysis chain
LGTM! But verify the model references in the codebase.
The code changes are approved.
However, ensure that all references to these models in the codebase are updated to match the new names.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all references to the updated models in the codebase. # Test: Search for the old model names. Expect: No occurrences of the old model names. rg --type js --type ts 'Position|Moves|DirectionsAvailable' # Test: Search for the new model names. Expect: Occurrences of the new model names. rg --type js --type ts 'dojo_starter-Position|dojo_starter-Moves|dojo_starter-DirectionsAvailable'Length of output: 26061
Summary by CodeRabbit