-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Resource limits and reserves Modules #104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot for the contribution @apavanello, very welcome!
Please see below a few comments - I noticed too late that I made my suggestions in the README, i.e. you'll need to move them to the source file (sorry).
It would be nice to add a test of this new functionality somewhere here but for this we first need an app installed during the verify
stage. Unfortunately, my PR #98 that would do this is blocked by a longstanding molecule bug and there doesn't seem to be any action on it... until that point no need to add a test
Change Allowed_keys to be agnostic
Hi, Maked changes on source to create a correct In test subject, i created a branch in my repo and added some tests and all have pass (you can check in my github actions https://github.com/apavanello/ansible-dokku/actions/runs/818794950), when #98 be fixed i can make another PR to implement the resources tests Sorry for english mistakes,i still learning the language |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in fact i don't need check the output of
dokku --quiet resource:limit myapp
because the output will have only two returns, the full list of resources (even when no have limits/reserves) and the error (when the app doesn't exist), so i use the current output to generate theallowed_keys
list, when dokku add new resources no need to change the list
great!
In test subject, i created a branch in my repo and added some tests and all have pass (you can check in my github actions https://github.com/apavanello/ansible-dokku/actions/runs/818794950)
Great, thanks for this!
when #98 be fixed i can make another PR to implement the resources tests
Cheers, I think I started to get an idea of where the molecule
issue comes from. Will ping you once this is done (but we will merge this PR nevertheless).
Sorry for english mistakes,i still learning the language
No worries!
The changes look good, just some final requests.
SMALL FIXES IN README
@ltalirz all done, changes sugested are maded. |
PR ref #103
Add two new lib files (
library/dokku_resource_limit.py
andlibrary/dokku_resource_reserve.py
) and update Readme