-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dokku_clone: add version
parameter and switch to git:sync
#98
Conversation
fe7b1de
to
a6200cb
Compare
version
parameterversion
parameter and switch to git:sync
Ran into a molecule bug. |
reuse functionality from dokku_app
for some reason, it is not finding the module_utils directory
c605ad8
to
a88f633
Compare
Would it makes sense to expose the
|
thanks for the suggestion @caillou , that would seem to make a lot of sense. I finally got a reply on the molecule issue some time ago, just haven't found the time to sit down and try the fixes. |
P.S. Would you be interested in reviewing this PR once it's ready? |
0c08325
to
a4800e0
Compare
Use workaround for importing the `library` and `module_utils` in the `verify.yml` playbook without actually running the role.
a4800e0
to
580f837
Compare
07defe0
to
54bce30
Compare
9f41cf8
to
e0be578
Compare
hi @caillou , I finally found the time to get back to this PR.
You don't necessarily need to go through all changes; I'm mainly concerned with |
@josegonzalez if you manage to have a quick look at I'll probably merge this tomorrow since it's going to be useful for the blog article |
I'm going ahead and merging this; happy to include updates in follow-up PRs. |
fixes #88
fixes #94
Use new
git:sync
command under the hood fordokku_clone
.Also, start reusing code between modules by placing code inside the
module_utils
folder.Further additions for fixing tests during the
verify
stage.Note: This requires
dokku >= 0.23.0
and will break thedokku_clone
command for previous dokku releases.I therefore suggest to