Pin the version of mysqlfw, add a comment, and a check to stop postgr…

…es (#3030)
dolthub · Mar 18, 2022 · 774c731 · 774c731
1 parent d2f21e5
commit 774c731
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/integration-tests/MySQLDockerfile b/integration-tests/MySQLDockerfile
@@ -106,7 +106,7 @@ RUN service postgresql start
 
 # install mysql_fdw
 WORKDIR /mysql-client-tests/mysql_fdw
-RUN git clone https://github.com/EnterpriseDB/mysql_fdw
+RUN git clone https://github.com/EnterpriseDB/mysql_fdw --branch REL-2_7_0
 WORKDIR /mysql-client-tests/mysql_fdw/mysql_fdw
 RUN make USE_PGXS=1 && \
     make USE_PGXS=1 install

diff --git a/integration-tests/mysql-client-tests/c/mysql-connector-c-test.c b/integration-tests/mysql-client-tests/c/mysql-connector-c-test.c
@@ -63,6 +63,7 @@ void test_statement(MYSQL *con, statement *stmt) {
       exit(1);
     }
   }
+  // TODO: Add test for mysql_stmt_store_result when supported
 close:
   if ( mysql_stmt_close(mstmt) ) {
     fprintf(stderr, "failed to close stmt: %s: %s\n", stmt->query, mysql_error(con));

diff --git a/integration-tests/mysql-client-tests/mysql-client-tests.bats b/integration-tests/mysql-client-tests/mysql-client-tests.bats
@@ -33,6 +33,12 @@ teardown() {
     cd ..
     kill $SERVER_PID
     rm -rf $REPO_NAME
+
+    # Check if postgresql is still running. If so stop it
+    active=$(service postgresql status)
+    if echo "$active" | grep "online"; then
+        service postgresql stop
+    fi
 }
 
 @test "go go-sql-drive/mysql test" {