only use crosshashjoin on subqueryaliases
#2339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jycor
changed the title
jycor
changed the title
crosshashjoin on subqueryaliases
max-hoffman
reviewed
Feb 22, 2024
sql/analyzer/indexed_joins.go
Outdated
| @@ -721,6 +721,12 @@ func addCrossHashJoins(m *memo.Memo) error { | |||
| return nil | |||
| } | |||
|
|
|||
| _, lIsSqa := join.Left.First.(*memo.SubqueryAlias) | |||
There was a problem hiding this comment.
there might be filters or projections in-between. you'll probably want to check the list of TableIdNodes in each group for a single SQA
max-hoffman
approved these changes
Feb 24, 2024
added 2 commits
February 23, 2024 20:00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes 2 sqllogictests.