Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only use crosshashjoin on subqueryaliases #2339

Merged
merged 12 commits into from
Feb 24, 2024
Merged

only use crosshashjoin on subqueryaliases #2339

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
fa928e1
remove crosshashjoins
Feb 22, 2024
df9818a
only use when there is sqa
Feb 22, 2024
ec6634c
fix join planning
Feb 22, 2024
4100b1c
regen plans
Feb 22, 2024
6d3d63a
Merge branch 'main' into james/join
Feb 22, 2024
06d8d80
tests
Feb 22, 2024
7f83d87
use fast join reorder in presence of crossjoin
Feb 23, 2024
2e61054
remove debug prints
Feb 23, 2024
4ab7b50
smaller repro
Feb 24, 2024
e824b9b
[ga-format-pr] Run ./format_repo.sh to fix formatting
jycor Feb 24, 2024
123e75b
feedbackg
Feb 24, 2024
1df9c38
these have hashcrossjoins i guess
Feb 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions enginetest/join_planning_tests.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,7 +589,7 @@ WHERE EXISTS (
},
{
q: `select * from xy where exists (select * from uv) and x = 0`,
types: []plan.JoinType{plan.JoinTypeCrossHash},
types: []plan.JoinType{plan.JoinTypeCross},
exp: []sql.Row{{0, 2}},
},
{
Expand Down Expand Up @@ -633,7 +633,7 @@ FROM xy
},
{
q: `select * from xy where exists (select * from uv join ab on u = a)`,
types: []plan.JoinType{plan.JoinTypeCrossHash, plan.JoinTypeMerge},
types: []plan.JoinType{plan.JoinTypeCross, plan.JoinTypeMerge},
exp: []sql.Row{{0, 2}, {1, 0}, {2, 1}, {3, 3}},
},
},
Expand Down Expand Up @@ -1278,7 +1278,7 @@ join uv d on d.u = c.x`,
},
{
q: "select * from vals where exists (select * from vals join ranges on val between min and max where min >= 2 and max <= 5)",
types: []plan.JoinType{plan.JoinTypeCrossHash, plan.JoinTypeInner},
types: []plan.JoinType{plan.JoinTypeCross, plan.JoinTypeInner},
exp: []sql.Row{
{nil},
{0},
Expand Down
46,344 changes: 23,780 additions & 22,564 deletions enginetest/queries/imdb_plans.go
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading