Reset computed height based on full version string #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kieranties
changed the title
|
@AArnott Do you have any feedback/guidance on this PR? I'm looking to start implementing builds soon and would love to have an official build supporting this. |
|
Looking now... |
|
There are some changes left to be made so that the answer is the same no matter which API is used. I'm working through it. |
|
I found a few inconsistencies around our support for |
Merged
|
Since the ultimate change for this includes breaking changes, your change is now part of a larger pull request that targets a new Thank you very much for getting this started, @Kieranties. |
|
Great stuff! |
AArnott
pushed a commit
that referenced
this pull request
Apr 1, 2024
Bumps [xunit](https://github.com/xunit/xunit) from 2.6.2 to 2.6.3. - [Commits](xunit/xunit@2.6.2...2.6.3) --- updated-dependencies: - dependency-name: xunit dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables option to compare full version string when calculating height reset. This resolves issue: #198.
By adding the following property to
version.json, the full version string is used for comparison during the calculation of the version height. The option requires explicit enablement to prevent breaking changes.