Fix version height bugs #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #239 by fixing up several more inconsistencies in calculating height when the height isn't in the build number position.
This is a breaking change, in that for folks who use the
{height}macro in theirversionproperty, the version height calculation will reset in more places than before, potentially causing folks who upgrade to this version of NB.GV to see their version number go backwards. Upgraders should use caution by checking their version number after the upgrade, and use theversionHeightOffsetproperty to artificially inflate it if necessary to ensure forward versioning.Fixes #198