Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to xamarin/Java.Interop/master@fdc200cc #5468

Merged
merged 1 commit into from
Jan 7, 2021

Commits on Jan 6, 2021

  1. Bump to xamarin/Java.Interop/master@fdc200cc

    Fixes: dotnet/java-interop#767
    
    Changes: dotnet/java-interop@7574f16...fdc200c
    
      * dotnet/java-interop@fdc200cc: [Xamarin.Android.Tools.Bytecode] Relax _ApiXml check (dotnet#772)
      * dotnet/java-interop@f1b93653: [generator] Change generated code to not emit CA1305 warning. (dotnet#771)
      * dotnet/java-interop@2244407d: [generator] Ensure DIM from assembly refs are correctly marked (dotnet#770)
      * dotnet/java-interop@da73d6a5: [Java.Interop] Prevent premature collection w/ JniInstance* (dotnet#768)
    
    Commit a7413a2 added support for invoking `java-source-utils.jar`
    on `@(JavaSourceJar)` to extract Javadoc comments and translate them
    into C# XML Documentation Comments.
    
    What this can *also* do is provide correct parameter names.
    As of commit a7413a2, the `BindingBuildTest.JavaSourceJar()`
    integration test would emit the warning:
    
    	obj/Debug/generated/src/Com.Xamarin.Android.Test.Msbuildtest.JavaSourceJarTest.cs(75,20):
    	warning CS1572: XML comment has a param tag for 'name', but there is no parameter by that name
    
    Commit dotnet/java-interop@fdc200cc allows `java-source-utils.jar`
    output to be used with `class-parse`, allowing
    `@(_JavaSourceJavadocXml)` files -- the output of
    `java-source-utils.jar` -- to be included in
    `@(_AndroidDocumentationPath)`.
    
    This allows `@(JavaSourceJar)` files to provide parameter names
    within bindings, removing the CS1572 warning, and making for
    better overall bindings.
    jonpryor committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    01fcfed View commit details
    Browse the repository at this point in the history