Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/installer #5954

Merged
merged 7 commits into from
May 28, 2021

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented May 24, 2021

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.NET.ILLink.Tasks: from 6.0.100-preview.5.21264.1 to 6.0.100-preview.6.21275.1 (parent: Microsoft.Dotnet.Sdk.Internal)
    • Microsoft.NETCore.App.Ref: from 6.0.0-preview.5.21265.5 to 6.0.0-preview.6.21274.1 (parent: Microsoft.Dotnet.Sdk.Internal)

From https://github.com/dotnet/installer

  • Subscription: 6548876b-06a1-4ab6-a5a5-08d8ed868088
  • Build: 20210526.2
  • Date Produced: 5/26/2021 1:22 PM
  • Commit: 3ebe0ca9715283842b003a75cf2b3603ca28d964
  • Branch: refs/heads/main

…210524.3

Microsoft.Dotnet.Sdk.Internal
 From Version 6.0.100-preview.5.21266.3 -> To Version 6.0.100-preview.6.21274.3

Dependency coherency updates

Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref
 From Version 6.0.100-preview.5.21264.1 -> To Version 6.0.100-preview.5.21271.1 (parent: Microsoft.Dotnet.Sdk.Internal
`System.Net.Quic.dll` seems to now be included for the Xamarin.Forms sample.
@dotnet-maestro dotnet-maestro bot requested a review from dellis1972 as a code owner May 24, 2021 15:56
@jonpryor
Copy link
Member

Mono.Android.NET_Tests is crashing on startup: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=4792895&view=ms.vss-test-web.build-test-results-tab&runId=21967336&resultId=100000&paneView=debug

The crash isn't shown on DevOps (ugh; why?), but can be found in the Artifacts > Test Results - APKs .NET - macOS > xa-test-results… link, in which logcat-Release-Mono.Android.NET_Tests.txt contains:

…
05-25 01:59:19.791  3412  3412 W monodroid: MonodroidRuntime::monodroid_pinvoke_override ("xa-internal-api", "monodroid_free")
05-25 01:59:19.791  3412  3412 I monodroid-timing: p/invoke cache lookup for 'monodroid_free' (internal); elapsed: 0s:0::40000
05-25 01:59:19.791  3412  3412 I monodroid-timing: p/invoke override for 'monodroid_free' (internal); elapsed: 0s:0::119000
05-25 01:59:19.791  3412  3412 W monodroid: Found xa-internal-api@monodroid_free in internal p/invoke map (0xcc4dd4a0)
05-25 01:59:19.822  3412  3412 I monodroid-timing: Typemap.managed_to_java: end, total time; elapsed: 0s:0::43000
05-25 01:59:19.917  3412  3412 F libc    : Fatal signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0 in tid 3412 (droid.NET_Tests), pid 3412 (droid.NET_Tests)
05-25 01:59:19.945  3434  3434 I crash_dump32: obtaining output fd from tombstoned, type: kDebuggerdTombstone
05-25 01:59:19.946  1665  1665 I /system/bin/tombstoned: received crash request for pid 3412
05-25 01:59:19.946  3434  3434 I crash_dump32: performing dump of process 3412 (target tid = 3412)
05-25 01:59:19.961  3434  3434 F DEBUG   : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
05-25 01:59:19.961  3434  3434 F DEBUG   : Build fingerprint: 'Android/sdk_phone_x86_64/generic_x86_64:10/QPP6.190730.005.B1/5775370:userdebug/test-keys'
05-25 01:59:19.961  3434  3434 F DEBUG   : Revision: '0'
05-25 01:59:19.961  3434  3434 F DEBUG   : ABI: 'x86'
05-25 01:59:19.962  3434  3434 F DEBUG   : Timestamp: 2021-05-25 01:59:19+0000
05-25 01:59:19.962  3434  3434 F DEBUG   : pid: 3412, tid: 3412, name: droid.NET_Tests  >>> Mono.Android.NET_Tests <<<
05-25 01:59:19.962  3434  3434 F DEBUG   : uid: 10103
05-25 01:59:19.962  3434  3434 F DEBUG   : signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0
05-25 01:59:19.962  3434  3434 F DEBUG   : Cause: null pointer dereference
05-25 01:59:19.962  3434  3434 F DEBUG   :     eax cd0fae44  ebx cd0ec454  ecx ffbacb78  edx e07a0880
05-25 01:59:19.962  3434  3434 F DEBUG   :     edi e08e3548  esi ffbacc34
05-25 01:59:19.963  3434  3434 F DEBUG   :     ebp ffbacb98  esp ffbacb5c  eip 00000000
05-25 01:59:20.327  3434  3434 F DEBUG   : 
05-25 01:59:20.327  3434  3434 F DEBUG   : backtrace:
05-25 01:59:20.327  3434  3434 F DEBUG   :       #00 pc 00000000  <unknown>
05-25 01:59:20.327  3434  3434 F DEBUG   :       #01 pc 0015c402  /data/app/Mono.Android.NET_Tests-yQedLY7Eb6bBwnAxp77XXg==/lib/x86/libmonosgen-2.0.so (GlobalizationNative_GetSortHandle+98) (BuildId: 0e934b920325375490167106c28bdd9c9e671321)
05-25 01:59:20.327  3434  3434 F DEBUG   :       #02 pc 00007415  <anonymous:e39a2000>

Looks like libmonosgen-2.0.so is triggering a SIGSEGV within GlobalizationNative_GetSortHandle+98.

dotnet-maestro bot and others added 3 commits May 26, 2021 16:28
…210526.2

Microsoft.Dotnet.Sdk.Internal
 From Version 6.0.100-preview.5.21266.3 -> To Version 6.0.100-preview.6.21276.2

Dependency coherency updates

Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref
 From Version 6.0.100-preview.5.21264.1 -> To Version 6.0.100-preview.6.21275.1 (parent: Microsoft.Dotnet.Sdk.Internal
@jonpryor
Copy link
Member

Current state of affairs: https://discord.com/channels/732297728826277939/732297837953679412/847192391567802448

We have a .apk which reliably crashes on startup: https://artprodscussu1.artifacts.visualstudio.com/A011b8bdf-6d56-4f87-be0d-0092136884d9/0bdbc590-a062-4c3f-b0f6-9383f67865ee/_apis/artifact/cGlwZWxpbmVhcnRpZmFjdDovL2RldmRpdi9wcm9qZWN0SWQvMGJkYmM1OTAtYTA2Mi00YzNmLWIwZjYtOTM4M2Y2Nzg2NWVlL2J1aWxkSWQvNDgwMjgyMi9hcnRpZmFjdE5hbWUvVGVzdCtSZXN1bHRzKy0rQVBLcysuTkVUKy0rbWFjT1Mr0/content?format=file&subPath=%2Fnet6-Default%2FMono.Android.NET_Tests-Signed.apk

For me on an arm64 Pixel 5 device, the crash is:

libc    : Fatal signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0 in tid 31880 (droid.NET_Tests), pid 31880 (droid.NET_Tests)
crash_dump64: obtaining output fd from tombstoned, type: kDebuggerdTombstone
tombstoned: received crash request for pid 31880
crash_dump64: performing dump of process 31880 (target tid = 31880)
DEBUG   : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
DEBUG   : Build fingerprint: 'google/redfin/redfin:11/RQ1A.201205.011/6966805:user/release-keys'
DEBUG   : Revision: 'MP1.0'
DEBUG   : ABI: 'arm64'
DEBUG   : Timestamp: 2021-05-26 15:21:42-0400
DEBUG   : pid: 31880, tid: 31880, name: droid.NET_Tests  >>> Mono.Android.NET_Tests <<<
DEBUG   : uid: 10282
DEBUG   : signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0
DEBUG   : Cause: null pointer dereference
DEBUG   :     x0  b400007c4de52530  x1  0000007fcc4cbeec  x2  fffffffffffffff0  x3  b400007d2de37c80
DEBUG   :     x4  b400007d2de37cf0  x5  0000000000000004  x6  0000007c2225ddac  x7  0000007fcc4cbfe0
DEBUG   :     x8  0000000000000000  x9  000000001333c921  x10 0000000000000000  x11 000000002de37cf0
DEBUG   :     x12 000000002a742e66  x13 0000000000000012  x14 0000000000000200  x15 0000000000000011
DEBUG   :     x16 0000007bd6adb810  x17 0000007ed2056240  x18 0000007ed3b94000  x19 0000007fcc4cc040
DEBUG   :     x20 b400007c4de52530  x21 b400007c4de52530  x22 0000000000000000  x23 b400007d7de490c0
DEBUG   :     x24 0000000000000001  x25 0000007bd58055c0  x26 0000007bd5cc0130  x27 0000007ed33ab000
DEBUG   :     x28 0000007bd6af1000  x29 0000007fcc4cbf00
DEBUG   :     lr  0000007bd69119c8  sp  0000007fcc4cbee0  pc  0000000000000000  pst 0000000080001000
…
DEBUG   : backtrace:
DEBUG   :       #00 pc 0000000000000000  <unknown>
DEBUG   :       #01 pc 000000000014e9c4  /data/app/~~oruJhhqj_EC_NWSaIGF_RQ==/Mono.Android.NET_Tests-G1iNxUwmGyu-tDRqYcK94g==/lib/arm64/libmonosgen-2.0.so (GlobalizationNative_GetSortHandle+76) (BuildId: 869ce5526fa884035199acac4ddc81bb6eeaf134)
DEBUG   :       #02 pc 000000000000ddbc  <anonymous:7c22250000>

The GlobalizationNative_GetSortHandle function is: https://github.com/dotnet/runtime/blob/044de838588006cf40b5656016b6ed26492c410f/src/libraries/Native/Unix/System.Globalization.Native/pal_collation.c#L404-L425

Now that I have an .apk to examine, I can disassemble libmonosgen-2.0.so for arm64:

000000000014e978 <GlobalizationNative_GetSortHandle>:
  14e978:	d100c3ff 	sub	sp, sp, #0x30
  14e97c:	a9014ff4 	stp	x20, x19, [sp,#16]
  14e980:	a9027bfd 	stp	x29, x30, [sp,#32]
  14e984:	910083fd 	add	x29, sp, #0x20
  14e988:	aa0003f4 	mov	x20, x0
  14e98c:	52806000 	mov	w0, #0x300                 	// #768
  14e990:	aa0103f3 	mov	x19, x1
  14e994:	97fb6ebb 	bl	2a480 <malloc@plt>
  14e998:	f9000260 	str	x0, [x19]
  14e99c:	b4000360 	cbz	x0, 14ea08 <GlobalizationNative_GetSortHandle+0x90>
  14e9a0:	52806002 	mov	w2, #0x300                 	// #768
  14e9a4:	2a1f03e1 	mov	w1, wzr
  14e9a8:	97fb738a 	bl	2b7d0 <memset@plt>
  14e9ac:	f0000e48 	adrp	x8, 319000 <_DYNAMIC+0x1878>
  14e9b0:	f941a508 	ldr	x8, [x8,#840]
  14e9b4:	910033e1 	add	x1, sp, #0xc
  14e9b8:	aa1403e0 	mov	x0, x20
  14e9bc:	b9000fff 	str	wzr, [sp,#12]
  14e9c0:	f9400108 	ldr	x8, [x8]
  14e9c4:	d63f0100 	blr	x8
  14e9c8:	f9400268 	ldr	x8, [x19]
  14e9cc:	f9000100 	str	x0, [x8]
  14e9d0:	b9400fe8 	ldr	w8, [sp,#12]
  14e9d4:	7100051f 	cmp	w8, #0x1
  14e9d8:	540000ab 	b.lt	14e9ec <GlobalizationNative_GetSortHandle+0x74>
  14e9dc:	f9400260 	ldr	x0, [x19]
  14e9e0:	97fb6e54 	bl	2a330 <free@plt>
  14e9e4:	f900027f 	str	xzr, [x19]
  14e9e8:	b9400fe8 	ldr	w8, [sp,#12]
  14e9ec:	3101f11f 	cmn	w8, #0x7c
  14e9f0:	52800040 	mov	w0, #0x2                   	// #2
  14e9f4:	54000120 	b.eq	14ea18 <GlobalizationNative_GetSortHandle+0xa0>
  14e9f8:	71003d1f 	cmp	w8, #0xf
  14e9fc:	540000e0 	b.eq	14ea18 <GlobalizationNative_GetSortHandle+0xa0>
  14ea00:	71001d1f 	cmp	w8, #0x7
  14ea04:	54000061 	b.ne	14ea10 <GlobalizationNative_GetSortHandle+0x98>
  14ea08:	52800060 	mov	w0, #0x3                   	// #3
  14ea0c:	14000003 	b	14ea18 <GlobalizationNative_GetSortHandle+0xa0>
  14ea10:	7100011f 	cmp	w8, #0x0
  14ea14:	1a9fd7e0 	cset	w0, gt
  14ea18:	a9427bfd 	ldp	x29, x30, [sp,#32]
  14ea1c:	a9414ff4 	ldp	x20, x19, [sp,#16]
  14ea20:	9100c3ff 	add	sp, sp, #0x30
  14ea24:	d65f03c0 	ret

The crash is at address 014e9c4, which is:

  14e9c4:	d63f0100 	blr	x8

We can see that CreateSortHandle() and GetResultCode() are inlined, e.g. 14e994 calls malloc@plt, which is in CreateSortHandle(). 14e9f8+ appears to be GetResultCode(); 0xf is U_BUFFER_OVERFLOW_ERROR, in pal_icushim_internal_android.h.

Which leaves 014e9c4: why is it crashing? What is register x8?

My guess is that it belongs to: https://github.com/dotnet/runtime/blob/044de838588006cf40b5656016b6ed26492c410f/src/libraries/Native/Unix/System.Globalization.Native/pal_collation.c#L416

    (*ppSortHandle)->collatorsPerOption[0] = ucol_open(lpLocaleName, &amp;err);

ppSortHandle can't be null; it's (eventually) called from: https://github.com/dotnet/runtime/blob/8eb13798e8b9033c995f7ea7ba2d4527089abe91/src/libraries/System.Private.CoreLib/src/System/Globalization/CompareInfo.Icu.cs#L814

Interop.Globalization.ResultCode resultCode = Interop.Globalization.GetSortHandle(sortName, out result);

and we can't fathom how out result would result in a NULL value.

*ppSortHandle can't be null; CreateSortHandle() allocates it, and if it were null, we'd have returned early, on pal_collation.c:411.

Hypothesis: we think that the crash could be because ucol_open is NULL. ucol_open is in fact a macro, which evaluates to ucol_open_ptr:

ucol_open_ptr is in turn set within FindICULibs

FindICULibs() is called by GlobalizationNative_LoadICU(): https://github.com/dotnet/runtime/blob/8eb13798e8b9033c995f7ea7ba2d4527089abe91/src/libraries/Native/Unix/System.Globalization.Native/pal_icushim.c#L387-L417

GlobalizationNative_LoadICU() is in turn called by Globalization.LoadICU(): https://github.com/dotnet/runtime/blob/8eb13798e8b9033c995f7ea7ba2d4527089abe91/src/libraries/Common/src/Interop/Interop.ICU.cs#L12-L13

which in turn is called by GlobalizationMode.LoadICU(): https://github.com/dotnet/runtime/blob/8eb13798e8b9033c995f7ea7ba2d4527089abe91/src/libraries/System.Private.CoreLib/src/System/Globalization/GlobalizationMode.LoadICU.Unix.cs

which in turn is called by GlobalizationMode.GetGlobalizationInvariantMode(): https://github.com/dotnet/runtime/blob/8eb13798e8b9033c995f7ea7ba2d4527089abe91/src/libraries/System.Private.CoreLib/src/System/Globalization/GlobalizationMode.Unix.cs#L28

What's possibly interesting here is that that GlobalizationMode.GetGlobalizationInvariantMode() only calls LoadICU() if invariantEnabled is false, i.e. if GetInvariantSwitchValue() returns false: https://github.com/dotnet/runtime/blob/8eb13798e8b9033c995f7ea7ba2d4527089abe91/src/libraries/System.Private.CoreLib/src/System/Globalization/GlobalizationMode.cs#L18-L19

Right now, we can't easily tell what GetInvariantSwitchValue() is actually returning; we think it should be returning false, as we build with $(InvariantGlobalization)=False, but we're not entirely sure.

We thus have two plausible scenarios:

  1. GetInvariantSwitchValue() is returning true, yet we're somehow getting into GlobalizationNative_GetSortHandle(), which likely makes no sense.

  2. We're somehow getting into GlobalizationNative_GetSortHandle() without hitting GlobalizationMode.Invariant.

@jonpryor
Copy link
Member

Related related: this isn't the first time we've seen a SIGSEGV related to GlobalizationNative_GetSortHandle; we also saw this in: #5669 (comment)

The fix in commit 8cd0b47 was to explicitly preserve the System.Globalization.GlobalizationMode type.

@jonpryor
Copy link
Member

Current dotnet/runtime diff: dotnet/runtime@6430375...5a26d12

@jonpryor
Copy link
Member

@steveisok: I think i have a coherent explanation. (Entirely untested, static analysis only.)

  1. System.Globalization.CompareInfo is constructed, eventually hitting CompareInfo.InitSort()

    [MemberNotNull(nameof(_sortName))]
    private void InitSort(CultureInfo culture)
    {
        _sortName = culture.SortName;
        if (GlobalizationMode.UseNls)
        {
            NlsInitSortHandle();
        }
        else
        {
            IcuInitSortHandle();
        }
    }
  2. Context: GlobalizationMode.UseNls:

    internal static bool UseNls => false;
  3. CompareInfo.cs:188 will trigger execution of the static constructor for GlobalizationMode. However, due to dotnet/runtime@bc27d49, the GlobalizationMode static constructor doesn't do much. In particular, the GlobalizationMode.Settings static constructor won't be executed, which in turn means GlobalizationMode.GetGlobalizationInvariantMode() won't be executed!

  4. CompareInfo.InitSort() then calls CompareInfo.IcuInitSortHandle()

  5. CompareInfo.IcuInitSortHandle() calls SortHandleCache.GetCachedSortHandle(_sortName).

  6. SortHandleCache.GetCachedSortHandle() calls Interop.Globalization.GetSortHandle(), which dovetails nicely with earlier investigation.

I strongly believe that dotnet/runtime@bc27d49 is what introduced the crash, by "removing" implicit ICU initialization from the GlobalizationMode static constructor.

@steveisok
Copy link
Member

steveisok commented May 27, 2021

@marek-safar does this seem like the linker may be getting in the way here? We aren't seeing this in the runtime tests at all.

@jonpryor
Copy link
Member

…enter mono --trace, which can be used to see which methods are executed.

We can enable mono --trace in a Xamarin.Android app via the debug.mono.trace system property:

adb shell setprop debug.mono.trace all

Once enabled, adb logcat gets spammed with every method which is executed:

05-26 22:18:50.633 18895 18895 V mono    : [0x7ed46024f8: 0.00000 0] 
05-26 22:18:50.633 18895 18895 V mono    : ENTER:c (wrapper runtime-invoke) <Module>:runtime_invoke_void__this___object (object,intptr,intptr,intptr)(
05-26 22:18:50.633 18895 18895 V mono    : [System.OutOfMemoryException:0x7bd5800048]
…
05-26 22:18:50.633 18895 18895 V mono    : ENTER:c System.OutOfMemoryException:.ctor (string)(

Thus, the question: is GetGlobalizationInvariantMode() executed?

% adb logcat > log.txt &

% adb shell am instrument -w Mono.Android.NET_Tests/xamarin.android.runtimetests.NUnitInstrumentation
INSTRUMENTATION_RESULT: shortMsg=Process crashed.
INSTRUMENTATION_CODE: 0

% fg
^C
# to stop `adb logcat` collection.

% grep GetGlobalizationInvariantMode log.txt
# no match

% grep GlobalizationNative_LoadICU log.txt
# no match

Before the crash, we do see:

05-26 22:29:41.381 19118 19118 V mono    : ENTER:c (wrapper managed-to-native) Interop/Globalization:GetSortHandle (string,intptr&)(
05-26 22:29:41.381 19118 19118 V mono    : [STRING:0x7bd6cc4130:]
05-26 22:29:41.381 19118 19118 V mono    : , 
05-26 22:29:41.381 19118 19118 V mono    : [BYREF:0x7fcc4ca210]
05-26 22:29:41.381 19118 19118 V mono    : )
05-26 22:29:41.381 19118 19118 V mono    : [0x7ed46024f8: 0.16952 11] 
05-26 22:29:41.381 19118 19118 V mono    : ENTER:c (wrapper managed-to-native) object:__icall_wrapper_mono_marshal_lookup_pinvoke (intptr)(
05-26 22:29:41.381 19118 19118 V mono    : 0xb400007dbdf06c40
05-26 22:29:41.381 19118 19118 V mono    : )
05-26 22:29:41.381 19118 19118 V mono    : [0x7ed46024f8: 0.16954 11] 
05-26 22:29:41.381 19118 19118 V mono    : LEAVE:c (wrapper managed-to-native) object:__icall_wrapper_mono_marshal_lookup_pinvoke (intptr)(
05-26 22:29:41.381 19118 19118 V mono    : result=0x7bd7a10978
05-26 22:29:41.381 19118 19118 V mono    : 
05-26 22:29:41.381 19118 19118 V mono    : [0x7ed46024f8: 0.16956 11] 
05-26 22:29:41.381 19118 19118 V mono    : ENTER:c (wrapper managed-to-native) object:__icall_wrapper_mono_string_to_utf8str (object)(
05-26 22:29:41.381 19118 19118 V mono    : [STRING:0x7bd6cc4130:]
05-26 22:29:41.381 19118 19118 V mono    : )
05-26 22:29:41.381 19118 19118 V mono    : [0x7ed46024f8: 0.16958 11] 
05-26 22:29:41.381 19118 19118 V mono    : LEAVE:c (wrapper managed-to-native) object:__icall_wrapper_mono_string_to_utf8str (object)(
05-26 22:29:41.381 19118 19118 V mono    : result=0xb400007c4de516b0
05-26 22:29:41.381 19118 19118 V mono    : 

@steveisok
Copy link
Member

steveisok commented May 27, 2021

Interesting finding.... If I run the tests w/ /p:PublishTrimmed=false, I do not crash. In fact, I get results from logcat

NUnit : Passed: 770, Failed: 1, Skipped: 2, Inconclusive: 0, Total: 0, Filtered: 0

Maybe an important side note: my terminal does say the process crashed. However, logcat says no such thing.

/Users/steve/dev/xamarin-android/build-tools/scripts/TestApks.targets(250,5): error : Instrumentation for component `Mono.Android.NET_Tests/xamarin.android.runtimetests.NUnitInstrumentation` did not exit successfully. Process crashed or test failures occurred! [/Users/steve/dev/xamarin-android/tests/Mono.Android-Tests/Runtime-Microsoft.Android.Sdk/Mono.Android.NET-Tests.csproj]
/Users/steve/dev/xamarin-android/build-tools/scripts/TestApks.targets(278,5): error : Application crash detected. Could not collect performance data. [/Users/steve/dev/xamarin-android/tests/Mono.Android-Tests/Runtime-Microsoft.Android.Sdk/Mono.Android.NET-Tests.csproj]

/cc @eerhardt

@jonpryor
Copy link
Member

@steveisok wrote:

my terminal does say the process crashed. However, logcat says no such thing.

This is ignorable. The file mentioned by the RunInstrumentationTests.LogcatFilename property (line 259) is never deleted:

https://github.com/xamarin/xamarin-android/blob/9add575ba0e25903b6894f40fcd53e6d51785fae/build-tools/scripts/TestApks.targets#L250-L266

Consequently, once a SIGSEGV is found, it's always found, even if it's no longer happening.

You can fix this by deleting the mentioned file and re-running the tests.

@jonpryor jonpryor merged commit da536fc into main May 28, 2021
@jonpryor jonpryor deleted the darc-main-702e706e-949d-422f-ae21-9155a2d3cf35 branch May 28, 2021 03:28
jonathanpeppers pushed a commit that referenced this pull request Feb 10, 2022
Context: #5954 (comment)
Context: #5605

This partially reverts da536fc.

In da536fc, we started seeing a crash around `$(InvariantGlobalization)`.

This is no longer needed since dotnet/runtime#53453 fixed the issue.

Bringing back the original optimization in #5605.
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants