Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove InvariantGlobalization workaround #6724

Merged

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented Feb 9, 2022

This is no longer needed since dotnet/runtime#53453 fixed the issue this was working around.

Bringing back the original optimization in #5605.

This is no longer needed since dotnet/runtime#53453 fixed the issue this was working around.

Bringing back the original optimization in dotnet#5605.
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah looks like da536fc #5954 was just working around a bug, and we never followed up.

Will just need to check the CI results.

@jonathanpeppers jonathanpeppers merged commit 0b448ab into dotnet:main Feb 10, 2022
@eerhardt eerhardt deleted the RemoveInvariantGlobalizationWorkaround branch February 10, 2022 15:00
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants