Remove support for v2 publishing in the templates (#8325) (#8383)

Part of the 1ES pool work would require moving a bunch of legacy, deprecated jobs to the 1ES pools for completeness. I see this as an opportunity to cut off v2 publishing, which should no longer be in use by anyone. While this is not a full removal from .NET Arcade's main, it removes the crucial templating support that enables repos to get into trouble.

Benefits include:
- Simplification of the templates - The allocation time on the 1ES pools will be signficantly longer. We may need to do work in the templates to mitigate this cost. Simplifying the templates will help in this effort
- Keep people from accidentally using V2 - There have been a number of repos over the last few months found to still be using v2, and getting broken as a result of changes. V2 is no longer supported as of .NET 5. Removal should help with this.

Documentation/CorePackages/Publishing.md

@@ -230,7 +230,7 @@ In order to use the new publishing mechanism, the easiest way to start is by tur
 
     | Name                                    | Type     | Description                                                                                          |Default Value |
     | --------------------------------------- | -------- | -----------------------------------------------------------------------------------------------------|----- |
-    | publishingInfraVersion                  | int      | Publishing infrastructure version - Use 3 for latest publishing infra. Accepted values are 2 / 3.                               | 2    |
+    | publishingInfraVersion                  | int      | Publishing infrastructure version - Use 3 for latest publishing infra. Accepted values are 3 (.NET 5.0+) and 2 (.NET 3.1).                               | 3    |
     | enableSourceLinkValidation              | bool     | Run SourceLink validation during the post-build stage.                                               | false |
     | enableSigningValidation                 | bool     | Run signing validation during the post-build stage.                                                  | true |
     | enableNugetValidation                   | bool     | Run NuGet package validation tool during the post build stage.                                       | true |
@@ -250,7 +250,7 @@ In order to use the new publishing mechanism, the easiest way to start is by tur
     * [Arcade-Validation](https://github.com/dotnet/arcade-validation/blob/master/azure-pipelines.yml)
     * [Arcade-Services](https://github.com/dotnet/arcade-services/blob/master/azure-pipelines.yml)
 
-1. Create or update eng/Publishing.props, adding the following MSBuild property:
+2. Create or update eng/Publishing.props, adding the following MSBuild property:
     ```XML
         <PublishingVersion>3</PublishingVersion>
     ```