Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for v2 publishing in the templates (#8325) #8383

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Jan 24, 2022

Part of the 1ES pool work would require moving a bunch of legacy, deprecated jobs to the 1ES pools for completeness. I see this as an opportunity to cut off v2 publishing, which should no longer be in use by anyone. While this is not a full removal from .NET Arcade's main, it removes the crucial templating support that enables repos to get into trouble.

Benefits include:

  • Simplification of the templates - The allocation time on the 1ES pools will be signficantly longer. We may need to do work in the templates to mitigate this cost. Simplifying the templates will help in this effort
  • Keep people from accidentally using V2 - There have been a number of repos over the last few months found to still be using v2, and getting broken as a result of changes. V2 is no longer supported as of .NET 5. Removal should help with this.

To double check:

Part of the 1ES pool work would require moving a bunch of legacy, deprecated jobs to the 1ES pools for completeness. I see this as an opportunity to cut off v2 publishing, which should no longer be in use by anyone. While this is not a full removal from .NET Arcade's main, it removes the crucial templating support that enables repos to get into trouble.

Benefits include:
- Simplification of the templates - The allocation time on the 1ES pools will be signficantly longer. We may need to do work in the templates to mitigate this cost. Simplifying the templates will help in this effort
- Keep people from accidentally using V2 - There have been a number of repos over the last few months found to still be using v2, and getting broken as a result of changes. V2 is no longer supported as of .NET 5. Removal should help with this.
@mmitche mmitche requested review from riarenas and epananth January 26, 2022 20:53
@mmitche
Copy link
Member Author

mmitche commented Jan 26, 2022

I'm going to port a bunch of template stuff over to 6.0 to streamline those builds and switch to the 1ES pools.

@mmitche mmitche merged commit 214dd59 into dotnet:release/6.0 Jan 26, 2022
@mmitche mmitche deleted the port-v2-pub-removal branch February 9, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants