Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for publishing of blobs to dotnetcli(checksums) storage #3607

Closed
riarenas opened this issue Aug 7, 2019 · 2 comments
Closed
Assignees

Comments

@riarenas
Copy link
Member

riarenas commented Aug 7, 2019

We don't have a great story using stages for blobs that need to be published to a final location (commonly the dotnetcli storage account)

Today, the pattern would be to implement a new stage that does the required steps, but we should find where the gaps are and see what makes sense to provide out of the box.

core-setup, core-sdk, and AspNetCore come to mind

CC @dagood, @livarcocc, @dougbu

@riarenas riarenas changed the title Finish support for publishing of blobs to a final location Add support for publishing of blobs to a final location Aug 7, 2019
@riarenas riarenas self-assigned this Aug 8, 2019
@riarenas
Copy link
Member Author

When working in the toolset repo, I was able to follow the pattern of:

  • Publish all blobs to build artifacts
  • Publish all blobs from build artifacts to a feed.

This worked well in toolset's case because they publish their blobs to the same feed as their packages. I'm working on allowing passing the credentials for the blob publish separately, so that it's possible to publish them to a different storage account.

@riarenas
Copy link
Member Author

#3697 adds a new publishInstallersAndChecksums parameter to the post-build yaml template. When set, the parameter will publish all installers and checksums in the asset manifests to the dotnetcli and dotnetclichecksums storage accounts.

Will keep the issue in validate, and will add the parameter to my current doc updates.

riarenas added a commit that referenced this issue Aug 27, 2019
Missed this during refactoring for #3607. For validation I was overriding the values to go to a test feed, so didn't catch this in the original PR.

The values for these variables are inverted.
riarenas added a commit that referenced this issue Aug 27, 2019
Missed this during refactoring for #3607. For validation I was overriding the values to go to a test feed, so didn't catch this in the original PR.

The values for these variables are inverted.
@riarenas riarenas changed the title Add support for publishing of blobs to a final location Add support for publishing of blobs to dotnetcli(checksums) storage Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant