Publish installers to dotnetcli / dotnetclichecksums for the dev chan… #3697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riarenas
commented
Aug 16, 2019
JohnTortugo
reviewed
Aug 16, 2019
src/Microsoft.DotNet.Arcade.Sdk/tools/SdkTasks/SetupTargetFeeds.proj
Outdated
Show resolved
Hide resolved
riarenas
commented
Aug 16, 2019
src/Microsoft.DotNet.Arcade.Sdk/tools/SdkTasks/SetupTargetFeeds.proj
Outdated
Show resolved
Hide resolved
|
New test build with all the latest changes and publishing to a test container in the storage accounts: https://dev.azure.com/dnceng/internal/_build/results?buildId=315910 Relevant logs: Container in dotnetcli: Container in dotnetclichecksums: @mmitche and @JohnTortugo this is ready for review again. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JohnTortugo
reviewed
Aug 19, 2019
| @@ -123,6 +136,16 @@ | |||
| TargetURL="$(TargetStaticFeed)" | |||
| Type="AzureStorageFeed" | |||
| Token="$(AzureStorageTargetFeedPAT)" /> | |||
| <TargetFeedConfig Condition="'$(PublishInstallersAndChecksums)' == 'true'" | |||
| Include="Deb;Rpm;Node;BinaryLayout;Installer;Maven;VSIX" | |||
There was a problem hiding this comment.
This binary layout thing (.zip files, right?) is also an installer?
There was a problem hiding this comment.
Yeah, zips, msis, etc. should all be on this layout. Does this handle that @riarenas
There was a problem hiding this comment.
Zip is handled by BinaryLayout, MSI is handled by Installer category
mmitche
approved these changes
Aug 20, 2019
mmitche
reviewed
Aug 20, 2019
| @@ -43,6 +48,14 @@ | |||
| Condition="('$(AzureStorageAccountName)' == '' or '$(AzureStorageAccountKey)' == '') and '$(IsStableBuild)' == 'true'" | |||
| Text="Parameters 'AzureStorageAccountName/Key' are empty." /> | |||
|
|
|||
| <Error | |||
There was a problem hiding this comment.
Does this handle stabilized builds? Publishing to a location that will not overwrite existing binaries?
There was a problem hiding this comment.
For stabilized binaries we already create a new container / feed on every build and publish everything there.
There was a problem hiding this comment.
Okay, so the installers make it there too.
Arcade does not publish installers or checksums, so disable this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to enable publishing installers to dotnetcli and checksums to dotnetclichecksums for #3607
I have only made the changes for the public channels.
I'm still testing to see if we can use proxies, or if the private version of this should wait until #3684
I'll provide a newer test build when I hack my stuff around the dotnet-install stuff, but wanted to see if this is the path we want to use.
This also cannot be merged until we have a new arcade SDK that includes the changes in #3696
I'm also thinking of adding a parameter to opt out of this publishing, for repos that already implemented something else for this.