Change the package description property to InstallerPackageDescription #15308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoritzinsky
commented
Dec 5, 2024
jkoritzinsky
added a commit
to jkoritzinsky/aspnetcore
that referenced
this pull request
Dec 5, 2024
…ion for installers (after dotnet/arcade#15308 flows)
ViktorHofer
approved these changes
Dec 5, 2024
jkoritzinsky
added a commit
to dotnet/aspnetcore
that referenced
this pull request
Dec 6, 2024
…de's installer tooling (#58612) * Add an sfxproj for the ref pack for Microsoft.AspNetCore.App. IT has the same contents except for some simplification of the analyzer layout and the PlatformManifest (which will be implemented correctly as part converting the runtime pack) * Add sfxproj-based runtime framework project * Produce the targeting pack archives * Build the runtime archive. There's some extra rebuilding now, so need to look into that. * Add a (mostly correct, some TODOs) composite runtime image and archive. * Use traversal projects to ensure that building the runtime archive projects directly restores the sfxprojs. * Add the new .deb packaging to the targeting pack * Add the aspnetcore runtime deb package to the sfxproj * Enable building RPM packages * Publish from the new-style projects to the correct subfolders for consuming projects to pick up. * Remove a TODO that's being addressed * Add support for partial R2R rooting based on dotnet/sdk#44436 * Reuse global properties and remove TODO addresed in corresponding Arcade PR. * Replace old shared framework projects and Linux installers with the new sfxproj and archive-based projects * Remove the NoTargets SDK, ended up using the Traversal SDK instead. * Fix path to runtime pack for manifest * Don't reference the installers package on Windows. We don't want to build MSIs with this tooling (yet) * Fix reference from aspnetcore-runtime and sequence the projects into the build better * Profive projects to build when only -buildinstallers is passed. This ensures we don't try to build AspNetCore.sln * Fix the path of the runtime list for testing. * Set property with file name * Disable APICompat for the archive projects. * Fix expected output directory for deb/rpm/targz/zip to be the shipping packages output. * Fix including zips (as wixpacks are still in the intsallers folder) * Build the shared frameworks via the transitive SDK proj only and make the native project references "just work" without a separate target. * Add PGO data via direct references to the MIBC files instead of flowing them through a different manner (that doesn't work) * Don't exclude the runtime archive traversal proj from the source-only build. * Add some makedirs * Don't try to extract the runtime we skipped downloading * Always prefer the ref assemblies in the transport pack over the impl assemblies when building the ref pack. * Add the right PackageOverrides.txt entries and make sure we exclude analyzers from the expected PackageOverrides list (they aren't supposed to be there) * Enable building all projects using the sharedfx sdk in source-build * Don't exclude the composite archive from source build. * Write out the aspnetcore_base_runtime.version file * Update aspnetcore-base-runtime.proj * Don't R2R when explicitly requested not to * Update .NET SDK to get composite image fix * Use the new RPM tooling and build debs/rpms in the regular build step (instead of as separate steps) * Remove rpmpkg references and update ref pack baseline version * Fix version string * Remove installers group on Build.props as the "managed" build will now correctly trigger debs/rpms when requested * Use Arcade RPM tooling for the Runtime sfxproj * Revert "Update .NET SDK to get composite image fix" This reverts commit b1b144d. * Don't pack the ref pack when only packing rid-specific packages * Remove RpmOwnedDirectory items as they're now provided by the SharedFramework SDK. * Don't build installers in source-build * Pass linux installer/archive artifacts over to the signing jobs * Don't publish the unsigned build if we're not doing post-build signing. We'll publish from the signing job. * Bulid installers on Linux-arm64 * Set the InstallerPackageDescription property to also set the description for installers (after dotnet/arcade#15308 flows) --------- Co-authored-by: Igor Velikorossov <RussKie@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PackageDescription has bad interactions with the NuGet targets. Use a different name that's just for installers.