-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert ref and runtime packs to use the SharedFramework SDK and Arcade's installer tooling #58612
Conversation
…the same contents except for some simplification of the analyzer layout and the PlatformManifest (which will be implemented correctly as part converting the runtime pack)
… to look into that.
…ojects directly restores the sfxprojs.
…suming projects to pick up.
…ew sfxproj and archive-based projects
…uild MSIs with this tooling (yet)
…ensures we don't try to build AspNetCore.sln
…g packages output.
Whoa, awesome! Feel free to ping me on Teams if/when you want me to take a look |
… the native project references "just work" without a separate target.
…nto sfx-aspnetcore
@@ -0,0 +1,66 @@ | |||
<Project Sdk="Microsoft.Build.Traversal"> | |||
<PropertyGroup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of this proj?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This project builds an archive containing the .NET runtime and the ASP.NET Core runtime with the Composite ReadyToRun image (which is used in some of our docker images).
Can you run an internal build of this branch so we can inspect the produced SharedFx/Targeting packs packages/installers? |
According to the official build, the targeting pack project is built and published from multiple legs:
|
Failures in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the only other thing would be to confirm the manifest from an internal build of this branch matches the manifest from an internal build of main
I ran an official build and it looks fine. However, the manually-triggered official build does in-build signing instead of post-build, so comparing apples-to-apples is difficult. I think this is okay for merge, but let me know if you think more validation is necessary. |
Fixed an issue with in-build signing, new official build at https://dev.azure.com/dnceng/internal/_build/results?buildId=2595419&view=results |
…g. We'll publish from the signing job.
New official build link: https://dev.azure.com/dnceng/internal/_build/results?buildId=2595988&view=results |
New official build link: https://dev.azure.com/dnceng/internal/_build/results?buildId=2596133&view=results |
…ion for installers (after dotnet/arcade#15308 flows)
Okay there's an ongoing infra issue that broke the official build. If this build produces the right installers for Linux arm64, we're good to merge (as that's the last thing I needed to validate). |
ARM64 rpms are being produced, setting auto-merge. |
<!-- Precompile the shared framework with ReadyToRun. ReadyToRun is not currently supported on s390x or ppc64le or armv6 or loongarch64. --> | ||
<PublishReadyToRun Condition=" '$(TargetArchitecture)' == 's390x' OR '$(TargetArchitecture)' == 'armv6' OR '$(TargetArchitecture)' == 'ppc64le' OR '$(TargetArchitecture)' == 'loongarch64' ">false</PublishReadyToRun> | ||
<!-- VMR doesn't produce valid crossgen for the host/build machine https://github.com/dotnet/source-build/issues/3793 --> | ||
<PublishReadyToRun Condition=" '$(DotNetBuild)' == 'true' AND '$(Crossbuild)' == 'true' ">false</PublishReadyToRun> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was surprised to see this. Are you sure that this is still an issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I believe that is still the case (to the point that I think I messed up this condition and we're seeing failures related to it in the Aspnet->SDK update).
I have some thoughts about it and I'll open an issue today to track fixing it.
Convert ref and runtime packs to use the SharedFramework SDK and Arcade's installer tooling (for Linux installers)
Replace the custom infrastructure in ASP.NET Core for building shared frameworks, .debs, and .rpms with the Arcade infrastructure
Description
Replace the custom infrastructure in this repo with the Arcade infrastructure. This provides a number of benefits:
Fixes #48013
Fixes #49486
Fixes #58073
Contributes to dotnet/source-build#3986
Depends on dotnet/arcade#15200
Depends on an SDK with dotnet/sdk#44436 (#58862)
Depends on dotnet/runtime#109169Replaces #58600
Depends on dotnet/arcade#15208
Depends on dotnet/arcade#15209
Depends on #58934