-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert ref and runtime packs to use the SharedFramework SDK and Arcade's installer tooling #58612
Draft
jkoritzinsky
wants to merge
23
commits into
dotnet:main
Choose a base branch
from
jkoritzinsky:sfx-aspnetcore
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+618
−3,668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the same contents except for some simplification of the analyzer layout and the PlatformManifest (which will be implemented correctly as part converting the runtime pack)
… to look into that.
…ojects directly restores the sfxprojs.
…suming projects to pick up.
…ew sfxproj and archive-based projects
jkoritzinsky
added
the
blocked
The work on this issue is blocked due to some dependency
label
Oct 24, 2024
dotnet-issue-labeler
bot
added
the
area-infrastructure
Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
label
Oct 24, 2024
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
…uild MSIs with this tooling (yet)
…ensures we don't try to build AspNetCore.sln
…g packages output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-infrastructure
Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
blocked
The work on this issue is blocked due to some dependency
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert ref and runtime packs to use the SharedFramework SDK and Arcade's installer tooling (for Linux installers)
Replace the custom infrastructure in ASP.NET Core for building shared frameworks, .debs, and .rpms with the Arcade infrastructure
Description
Replace the custom infrastructure in this repo with the Arcade infrastructure. This provides a number of benefits:
Fixes #48013
Fixes #49486
Fixes #58073
Depends on dotnet/arcade#15200
Depends on an SDK with dotnet/sdk#44436
Depends on dotnet/runtime#109169
Replaces #58600