Add more extensions and categories to publish #3824
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -511,6 +511,12 @@ private string InferCategory(string assetId) | |
| { ".SHA", "CHECKSUM" }, | ||
| { ".POM", "MAVEN" }, | ||
| { ".VSIX", "VSIX" }, | ||
| { ".CAB", "BINARYLAYOUT" }, | ||
| { ".TAR", "BINARYLAYOUT" }, | ||
| { ".GZ", "BINARYLAYOUT" }, | ||
| { ".TGZ", "BINARYLAYOUT" }, | ||
| { ".EXE", "INSTALLER" }, | ||
| { ".SVG", "BADGE"} | ||
|
There was a problem hiding this comment. The categories listed here should have a matching category+target feed config here: https://github.com/dotnet/arcade/blob/master/src/Microsoft.DotNet.Arcade.Sdk/tools/SdkTasks/SetupTargetFeeds.proj otherwise the packages of that category won't be published. The BADGE category doesn't have a TFC. There was a problem hiding this comment. I need a new version of the task that includes the category, otherwise I get an error when trying to use the BADGE category There was a problem hiding this comment. Is it possible to remove the need for this mapping here? It means we have to update DefaultVersions.props every time we have a new category. There was a problem hiding this comment. Ricardo and I talked about this. He's going to create an issue for it. There was a problem hiding this comment. We should definitely look at a better way to handle these and had some discussion with @JohnTortugo and @jcagme that I captured in #3828 I'm first trying to unblock the core-sdk migration by adding these. I can also simply have the PublishInstallers feedConfig just publish the NETCORE category which is the fallback category and that would encompass everything that gets published to the main feeds. Let me know if you'd rather I take that approach. |
||
| }; | ||
|
|
||
| if (whichCategory.TryGetValue(extension, out var category)) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this list seems to be complete, the fact of having to keep this updated makes me feel a bit off. At the same time, I don't think we can have the package read some sort of config file which is not part of the package itself (so a change on this list doesn't need a full build -> version push) in case this needs to be source build (no internet) so I guess this is ok :)