Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump codeanalysisVersion to make it understand nullablity #4796

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Bump codeanalysisVersion to make it understand nullablity #4796

merged 1 commit into from
Feb 10, 2020

Conversation

Anipik
Copy link
Contributor

@Anipik Anipik commented Feb 8, 2020

I published the package locally and tested it by building runtime repo that the msbuild version of codeAnalysis doesn't interfere with this one.

@eiriktsarpalis eiriktsarpalis mentioned this pull request Feb 10, 2020
Merged
@Anipik Anipik merged commit 175e7ae into dotnet:master Feb 10, 2020
@Anipik Anipik deleted the nullable branch February 10, 2020 17:49
safern
safern reviewed Feb 10, 2020
View reviewed changes
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eiriktsarpalis
Copy link
Member

Hi @Anipik, has the change been incorporated in dotnet/runtime? I see that the package was recently updated in a PR.

However my PR is still failing, even though I rebased on top of the latest master:
https://dev.azure.com/dnceng/public/_build/results?buildId=517577&view=logs&j=0ce95488-260d-5e86-47b9-82bc4e703e0b&t=fc172bf4-4375-570c-6063-be42dda01a5a&l=757

@Anipik
Copy link
Contributor Author

Anipik commented Feb 12, 2020

@eiriktsarpalis I am just debugging your change to see what causing this.

@Anipik
Copy link
Contributor Author

Anipik commented Feb 12, 2020

@eiriktsarpalis the change from arcade have not yet merged into the corefx dotnet/runtime#32115 this contains the arcade change. @ViktorHofer is trying to get the pr merged.

@eiriktsarpalis
Copy link
Member

Can confirm that the issue has been fixed in my branch. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@safern safern safern left review comments

@ericstj ericstj ericstj approved these changes

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Anipik @eiriktsarpalis @ericstj @safern