Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nullable annotate System.Drawing.Common #31716

Merged
merged 9 commits into from
Feb 26, 2020
Merged

Nullable annotate System.Drawing.Common #31716

merged 9 commits into from
Feb 26, 2020

Conversation

eiriktsarpalis
Copy link
Member

Contributes to #2339

@eiriktsarpalis eiriktsarpalis force-pushed the annotate-system-drawing-common branch 4 times, most recently from 173842e to 5da7054 Compare February 7, 2020 11:06
@eiriktsarpalis
Copy link
Member Author

PR blocked until dotnet/arcade#4796 is merged and package update in runtime

@eiriktsarpalis eiriktsarpalis force-pushed the annotate-system-drawing-common branch 2 times, most recently from cce73df to 11bea39 Compare February 13, 2020 10:52
@eiriktsarpalis eiriktsarpalis self-assigned this Feb 13, 2020
@eiriktsarpalis eiriktsarpalis force-pushed the annotate-system-drawing-common branch 2 times, most recently from c9212da to 0deb871 Compare February 18, 2020 12:43
@eiriktsarpalis eiriktsarpalis force-pushed the annotate-system-drawing-common branch from ccde3f3 to 632ebd3 Compare February 20, 2020 13:08
buyaa-n
buyaa-n reviewed Feb 24, 2020
View reviewed changes
src/libraries/System.Drawing.Common/src/System/Drawing/Printing/PrintDocument.Windows.cs

private PrinterSettings _printerSettings = new PrinterSettings();
private PageSettings _defaultPageSettings;

private PrintController _printController;
private PrintController? _printController;

private bool _originAtMargins;
private bool _userSetPageSettings;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Below on row 151-196 event accessors BeginPrint, EndPrint, PrintPage, QueryPageSettings should be nullable

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do they need to be nullable?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about that, but that is what we were doing before for event accessors CC @stephentoub

buyaa-n
buyaa-n approved these changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, other than that LGTM, thanks!

@eiriktsarpalis eiriktsarpalis force-pushed the annotate-system-drawing-common branch from 5dbdbd2 to fe36f59 Compare February 25, 2020 18:00
This was referenced Feb 25, 2020
Closed
Closed
@eiriktsarpalis eiriktsarpalis merged commit f5ecd6b into dotnet:master Feb 26, 2020
@eiriktsarpalis eiriktsarpalis deleted the annotate-system-drawing-common branch February 26, 2020 10:44
safern
safern reviewed Mar 10, 2020
View reviewed changes
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @eiriktsarpalis -- LGTM

@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@buyaa-n buyaa-n buyaa-n approved these changes

@safern safern safern left review comments

@JeremyKuhne JeremyKuhne JeremyKuhne left review comments

@stephentoub stephentoub Awaiting requested review from stephentoub

Assignees

@eiriktsarpalis eiriktsarpalis

Labels
area-System.Drawing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eiriktsarpalis @JeremyKuhne @safern @buyaa-n