Update known frameworks to test against #7482
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Anipik looks like netcoreapp3.1 isn't chosen because it isn't the min version and netcoreapp2.0 isn't in the list. Is that assumption right? If yes, what would need to change to choose the minimum supported .NETCoreApp version based on our support policy and not based on the netstandard compatibility matrix? |
|
Will take a look at the failures here later today. |
|
thanks 👍 |
|
@ViktorHofer we can close this one. the tests and code here has drastically changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To double check:
Removing net463 and net46 as these newer shipped a targeting pack and these tfms are already disabled in dotnet/runtime's package validation.
Removing tfms that aren't supported in dotnet/runtime anymore.