[release/5.0] Fix strict-mode break

[dougbu]

• use Get-Member instead of assuming $null property value
• fixes build break I caused in 0214a32

To double check:

• The right tests are in and and the right validation has happened. Guidance: https://github.com/dotnet/core-eng/tree/master/Documentation/Validation

Tested fix locally in the dotnet/aspnetcore repo

[dougbu]

/fyi @rainersigwald @ryalanms

[dougbu]

Oh "neat" (😃). I could merge here even though I can't merge into release/3.x (or wasn't able to the other day). Is that a hole in your security @MattGal @mmitche @ilyas1974 @riarenas❔

[rainersigwald]

This doesn't appear to have triggered a build

❯ darc get-latest-build --channel ".NET 5 Eng" --repo dotnet/arcade
Repository:    https://github.com/dotnet/arcade
Branch:        release/5.0
Commit:        0214a32e5fceaedc18042969a524f48a37c22be8
Build Number:  20210624.1
Date Produced: 6/24/2021 10:30 AM
Build Link:    https://dev.azure.com/dnceng/internal/_build/results?buildId=1204098
BAR Build Id:  95397
Released:      False
Channels:
- .NET 5 Eng
- .NET 5 Eng - Validation

Repository:    https://github.com/dotnet/arcade
Branch:        release/5.0
Commit:        0214a32e5fceaedc18042969a524f48a37c22be8
Build Number:  20210624.1
Date Produced: 6/24/2021 10:30 AM
Build Link:    https://dev.azure.com/dnceng/internal/_build/results?buildId=1204098
BAR Build Id:  95397
Released:      False
Channels:
- .NET 5 Eng
- .NET 5 Eng - Validation

Any idea what's up with that?

(Not urgent, was just looking at dotnet/msbuild#6625 with @AR-May and noticed that we got the break but not the fix.)

[riarenas]

I'm still catching up from being away, but I believe it's related with mirroring being broken late last week. This commit is not present in the internal mirror, so it never triggered a build.

[riarenas]

Triggered https://dev.azure.com/dnceng/internal/_build/results?buildId=1209402&view=logs&j=a3453f18-ed27-56b8-78ee-81a7631275fb which should mirror the change

[riarenas]

https://dev.azure.com/dnceng/internal/_build/results?buildId=1209415&view=results is the official build for this. I'll make sure to trigger all 5.0 arcade subs once this change goes through validation and is available in the channels.

[dougbu]

@riarenas could you do the same for the 'main' branch please❔ dotnet/sdk#18542 for example picked up 20210624.3 and https://maestro-prod.westus2.cloudapp.azure.com/2/https:%2F%2Fdev.azure.com%2Fdnceng%2Finternal%2F_git%2Fdotnet-arcade/latest/graph says there isn't a newer build, despite a number of additional commits in the branch (including my #7564 fix).

[dougbu]

darc get-latest-build --channel '.NET Eng - Latest' --repo arcade also shows the 20210624.3 build as the latest.

[riarenas]

@dougbu, the main branch seems to be up to date as of today. https://dev.azure.com/dnceng/internal/_build/results?buildId=1209256&view=results is the latest build that is a candidate for promotion.

[dougbu]

a candidate for promotion

What's the promotion schedule❔ I ask because the #7564 fix is needed to ingest the current build in the channel (v20210624.3). That contains the build break but not the fix,

[riarenas]

We promote every build automatically as long as the 3 bellwether repos are green in their official build. The last few builds have been stalled because of aspnetcore's main build being broken due to the msbuild issues in newer .net sdks.

[dougbu]

aspnetcore's main build being broken due to the msbuild issues in newer .net sdks

Fix is in PR. See dotnet/aspnetcore#33922

[riarenas]

@dougbu, I created #7567 so we can plug the hole.

[dougbu]

dotnet/aspnetcore#33922 fix for our 'main' branch is in though an official build (https://dev.azure.com/dnceng/internal/_build/results?buildId=1210262&view=results) only just started. Could we optimistically trigger the promotion validation❔

[riarenas]

The check will take about a minute, we just need to retry the final stage of this build: https://dev.azure.com/dnceng/internal/_build/results?buildId=1209416&view=results

So we can just trigger that as soon as there's a successful official build.

[riarenas]

@dougbu the build is in the channel and repos can expect the fix to update the existing failing PRs tomorrow morning

[dougbu]

@dougbu the build is in the channel

Yeah, darc get-latest-build --channel '.NET Eng - Latest' --repo arcade looks happier 😀

repos can expect the fix to update the existing failing PRs tomorrow morning

Is that true for repos w/ weekly subscriptions to '.NET Eng - Latest'❔ I seem to recall dependency update PRs aren't updated more frequently than the relevant subscription unless someone runs darc trigger-subscriptions. While dotnet/sdk#18542 will look better tomorrow (/fyi @lewing), I triggered the subscription into dotnet/aspnetcore to get dotnet/aspnetcore#33879 going before next Sunday (/fyi @halter73). (Think our subscription from Arcade usually triggers on Sunday.)

The subset of repos that darc get-subscriptions --source-repo arcade$ --regex --channel '.NET Eng - Latest' --frequencies everyWeek lists which use msbuild from VS may have open (busted) PRs that'll wait for up to a week for the fix.

---

Apologies to all for having most of the conversation about the fix in 'main' in this 'release/5.0'-targeting PR. Rather confuzzzed…

[riarenas]

@dougbu to be more specific, the change would make it through as your subscriptions have it configured. Most repos use a daily cadence to get arcade changes. Repos can always trigger their subscriptions manually if they wish to get the change earlier.