-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Fix strict-mode break #7564
Conversation
- use `Get-Member` instead of assuming `$null` property value - fixes build break I caused in 13040ff
/fyi @rainersigwald @ryalanms |
Question for all: How did 13040ff get past the CI❔ The build was green for both #7559 and #7558 even though taking the change into dotnet/wpf failed in dotnet/wpf#4750 |
OIC the break wouldn't be detected unless part of the build required desktop |
We exercise the desktop msbuild path with the usage of the signcheck tool during the signing validation job: IE. https://dev.azure.com/dnceng/internal/_build/results?buildId=1209416&view=logs&j=b11b921d-8982-5bb3-754b-b114d42fd804&t=cdcedd1f-8008-523f-9da1-cc35fbfef9a3, but there are no explicit tests for this, and clearly there's a hole since this PR had to be fix things. |
Agreed. That build step used an xcopy |
- use `Get-Member` instead of assuming `$null` property value - fixes build break I caused in 13040ff
Get-Member
instead of assuming$null
property valueTo double check:
Tested fix locally in the dotnet/aspnetcore repo